Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

fix shadowed variable in CustomView (#743)

Browse Source 
This corrects a minor linting problem that recently crept in, by
renaming a variable.
This commit is contained in:
Paul Fitzpatrick 2023-11-13 10:56:01 -05:00 committed by GitHub
parent 68801474b1
commit 2f96a56150
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/client/components/CustomView.ts
View File

@ -242,7 +242,7 @@ export class CustomView extends Disposable {
const {baseUrl, access, showAfterReady, widgetId, pluginId} = options;
const documentSettings = this.gristDoc.docData.docSettings();
const readonly = this.gristDoc.isReadonly.get();
const frame = WidgetFrame.create(null, {
const widgetFrame = WidgetFrame.create(null, {
url: baseUrl || this.getEmptyWidgetPage(),
widgetId,
pluginId,
@ -309,7 +309,7 @@ export class CustomView extends Disposable {
// array of nodes (comment, node, comment) and it somehow breaks the dispose order. Collapsed widgets
// relay on a correct order of dispose, and are detaching nodes just before they are disposed, so if
// the order is wrong, the node is disposed without being detached first.
return grains.update(frame.buildDom(), dom.autoDispose(frame));
return grains.update(widgetFrame.buildDom(), dom.autoDispose(widgetFrame));
}
}