From 2f96a561507d98e6f7b365d7210651ba718e33d3 Mon Sep 17 00:00:00 2001 From: Paul Fitzpatrick Date: Mon, 13 Nov 2023 10:56:01 -0500 Subject: [PATCH] fix shadowed variable in CustomView (#743) This corrects a minor linting problem that recently crept in, by renaming a variable. --- app/client/components/CustomView.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/client/components/CustomView.ts b/app/client/components/CustomView.ts index e9a256bb..befe36ba 100644 --- a/app/client/components/CustomView.ts +++ b/app/client/components/CustomView.ts @@ -242,7 +242,7 @@ export class CustomView extends Disposable { const {baseUrl, access, showAfterReady, widgetId, pluginId} = options; const documentSettings = this.gristDoc.docData.docSettings(); const readonly = this.gristDoc.isReadonly.get(); - const frame = WidgetFrame.create(null, { + const widgetFrame = WidgetFrame.create(null, { url: baseUrl || this.getEmptyWidgetPage(), widgetId, pluginId, @@ -309,7 +309,7 @@ export class CustomView extends Disposable { // array of nodes (comment, node, comment) and it somehow breaks the dispose order. Collapsed widgets // relay on a correct order of dispose, and are detaching nodes just before they are disposed, so if // the order is wrong, the node is disposed without being detached first. - return grains.update(frame.buildDom(), dom.autoDispose(frame)); + return grains.update(widgetFrame.buildDom(), dom.autoDispose(widgetFrame)); } }