simplified test structure

test/webfuse_provider/provider/operation/test_close.cc

@@ -0,0 +1,99 @@
+#include "webfuse_provider/impl/operation/close.h"
+#include "webfuse_provider/mocks/mock_provider.hpp"
+#include "webfuse_provider/mocks/fake_invokation_context.hpp"
+
+#include <gtest/gtest.h>
+
+using ::webfuse_test::MockProvider;
+using ::webfuse_test::create_context;
+using ::testing::_;
+
+TEST(wfp_close, close)
+{
+    int inode = 42;
+    int handle = 0xdeadbeef;
+    int flags = 23;
+
+    MockProvider provider;
+    EXPECT_CALL(provider, close(inode, handle, flags)).Times(1);
+
+    wfp_impl_invokation_context context = create_context(provider);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(inode));
+    json_array_append_new(params, json_integer(handle));
+    json_array_append_new(params, json_integer(flags));
+
+    wfp_impl_close(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_close, close_fail_invalid_param_count)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, close(_,_,_)).Times(0);
+
+    wfp_impl_invokation_context context = create_context(provider);
+
+    json_t * params = json_array();
+    wfp_impl_close(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_close, close_fail_inode_invalid_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, close(_,_,_)).Times(0);
+
+    wfp_impl_invokation_context context = create_context(provider);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_string("42"));
+    json_array_append_new(params, json_integer(0));
+    json_array_append_new(params, json_integer(0));
+
+    wfp_impl_close(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_close, close_fail_handle_invalid_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, close(_,_,_)).Times(0);
+
+    wfp_impl_invokation_context context = create_context(provider);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(0));
+    json_array_append_new(params, json_string("42"));
+    json_array_append_new(params, json_integer(0));
+
+    wfp_impl_close(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_close, close_fail_flags_invalid_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, close(_,_,_)).Times(0);
+
+    wfp_impl_invokation_context context = create_context(provider);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(0));
+    json_array_append_new(params, json_integer(0));
+    json_array_append_new(params, json_string("42"));
+
+    wfp_impl_close(&context, params, 42);
+    json_decref(params);
+}
+
+
+TEST(wfp_close, default_nop)
+{
+    wfp_impl_close_default(0, 0, 0, nullptr);
+}

test/webfuse_provider/provider/operation/test_getattr.cc

@@ -0,0 +1,107 @@
+#include "webfuse_provider/impl/operation/getattr.h"
+#include "webfuse_provider/mocks/mock_request.hpp"
+#include "webfuse_provider/mocks/mock_provider.hpp"
+#include "webfuse_provider/mocks/fake_invokation_context.hpp"
+
+#include <gtest/gtest.h>
+#include <cstdlib>
+
+using ::webfuse_test::MockProvider;
+using ::webfuse_test::MockRequest;
+using ::webfuse_test::StatMatcher;
+using ::webfuse_test::create_context;
+using ::testing::_;
+using ::testing::Invoke;
+
+namespace
+{
+
+void free_request(wfp_request * request, ino_t)
+{
+    free(request);
+}
+
+}
+
+TEST(wfp_impl_getattr, default_responds_error)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond_error(_,42)).Times(1);
+
+    wfp_impl_getattr_default(req, 0, nullptr);
+}
+
+TEST(wfp_impl_getattr, respond_file)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(StatMatcher(23, 0754, "file"), 42)).Times(1);
+
+    struct stat buffer;
+    memset(&buffer, 0, sizeof(buffer));
+    buffer.st_ino = 23;
+    buffer.st_mode = S_IFREG | 0754;
+    wfp_impl_respond_getattr(req, &buffer);
+}
+
+TEST(wfp_impl_getattr, respond_dir)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(StatMatcher(23, 0754, "dir"), 42)).Times(1);
+
+    struct stat buffer;
+    memset(&buffer, 0, sizeof(buffer));
+    buffer.st_ino = 23;
+    buffer.st_mode = S_IFDIR | 0754;
+    wfp_impl_respond_getattr(req, &buffer);
+}
+
+TEST(wfp_impl_getattr, invoke_provider)
+{
+    ino_t inode = 23;
+    MockProvider provider;
+    EXPECT_CALL(provider,getattr(_, inode)).Times(1).WillOnce(Invoke(free_request));
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(inode));
+
+    wfp_impl_getattr(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_getattr, fail_invalid_param_count)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,getattr(_, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+
+    wfp_impl_getattr(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_getattr, fail_invalid_inode_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,getattr(_, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_string("42"));
+
+    wfp_impl_getattr(&context, params, 42);
+    json_decref(params);
+}

test/webfuse_provider/provider/operation/test_lookup.cc

@@ -0,0 +1,129 @@
+#include "webfuse_provider/impl/operation/lookup.h"
+#include "webfuse_provider/mocks/mock_request.hpp"
+#include "webfuse_provider/mocks/mock_provider.hpp"
+#include "webfuse_provider/mocks/fake_invokation_context.hpp"
+
+#include <gtest/gtest.h>
+#include <cstdlib>
+
+using ::webfuse_test::MockProvider;
+using ::webfuse_test::MockRequest;
+using ::webfuse_test::StatMatcher;
+using ::webfuse_test::create_context;
+using ::testing::_;
+using ::testing::Invoke;
+using ::testing::StrEq;
+
+namespace
+{
+
+void free_request(wfp_request * request, ino_t, char const *)
+{
+    free(request);
+}
+
+}
+
+TEST(wfp_impl_lookup, invoke_provider)
+{
+    ino_t inode = 42;
+    MockProvider provider;
+    EXPECT_CALL(provider,lookup(_, inode,StrEq("some.file"))).Times(1)
+        .WillOnce(Invoke(free_request));
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(inode));
+    json_array_append_new(params, json_string("some.file"));
+
+    wfp_impl_lookup(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_lookup, fail_invalid_param_count)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,lookup(_, _,_)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(23));
+
+    wfp_impl_lookup(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_lookup, fail_invalid_inode_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,lookup(_, _,_)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_string("23"));
+    json_array_append_new(params, json_string("some.file"));
+
+    wfp_impl_lookup(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_lookup, fail_invalid_name_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,lookup(_, _,_)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(23));
+    json_array_append_new(params, json_integer(1));
+
+    wfp_impl_lookup(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_lookup, default_responds_error)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond_error(_,42)).Times(1);
+
+    wfp_impl_lookup_default(req, 1, "some.file", nullptr);
+}
+
+TEST(wfp_impl_lookup, respond_file)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(StatMatcher(23, 0754, "file"), 42)).Times(1);
+
+    struct stat buffer;
+    memset(&buffer, 0, sizeof(buffer));
+    buffer.st_ino = 23;
+    buffer.st_mode = S_IFREG | 0754;
+    wfp_impl_respond_lookup(req, &buffer);
+}
+
+TEST(wfp_impl_lookup, respond_dir)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(StatMatcher(23, 0754, "dir"), 42)).Times(1);
+
+    struct stat buffer;
+    memset(&buffer, 0, sizeof(buffer));
+    buffer.st_ino = 23;
+    buffer.st_mode = S_IFDIR | 0754;
+    wfp_impl_respond_lookup(req, &buffer);
+}

test/webfuse_provider/provider/operation/test_open.cc

@@ -0,0 +1,114 @@
+#include "webfuse_provider/impl/operation/open.h"
+#include "webfuse_provider/mocks/mock_request.hpp"
+#include "webfuse_provider/mocks/mock_provider.hpp"
+#include "webfuse_provider/mocks/fake_invokation_context.hpp"
+
+#include <gtest/gtest.h>
+#include <cstdlib>
+
+using ::webfuse_test::MockProvider;
+using ::webfuse_test::MockRequest;
+using ::webfuse_test::OpenMatcher;
+using ::webfuse_test::create_context;
+using ::testing::_;
+using ::testing::Invoke;
+using ::testing::StrEq;
+
+namespace
+{
+
+void free_request(wfp_request * request, ino_t, int)
+{
+    free(request);
+}
+
+}
+
+TEST(wfp_impl_open, invoke_provider)
+{
+    ino_t inode = 42;
+    int flags = 0;
+    MockProvider provider;
+    EXPECT_CALL(provider,open(_, inode, flags)).Times(1)
+        .WillOnce(Invoke(free_request));
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(inode));
+    json_array_append_new(params, json_integer(flags));
+
+    wfp_impl_open(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_open, fail_invalid_param_count)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,open(_, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(23));
+
+    wfp_impl_open(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_open, fail_invalid_inode_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,open(_, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_string(""));
+    json_array_append_new(params, json_integer(0));
+
+    wfp_impl_open(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_open, fail_invalid_flags_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,open(_, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(23));
+    json_array_append_new(params, json_string(""));
+
+    wfp_impl_open(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_open, default_responds_error)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond_error(_,42)).Times(1);
+
+    wfp_impl_open_default(req, 1, 0, nullptr);
+}
+
+TEST(wfp_impl_open, respond)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(OpenMatcher(23), 42)).Times(1);
+
+    wfp_impl_respond_open(req, 23);
+}
+

test/webfuse_provider/provider/operation/test_read.cc

@@ -0,0 +1,173 @@
+#include "webfuse_provider/impl/operation/read.h"
+#include "webfuse_provider/mocks/mock_request.hpp"
+#include "webfuse_provider/mocks/mock_provider.hpp"
+#include "webfuse_provider/mocks/fake_invokation_context.hpp"
+
+#include <gtest/gtest.h>
+#include <cstdlib>
+
+using ::webfuse_test::MockProvider;
+using ::webfuse_test::MockRequest;
+using ::webfuse_test::ReadResultMatcher;
+using ::webfuse_test::create_context;
+using ::testing::_;
+using ::testing::Invoke;
+using ::testing::StrEq;
+
+namespace
+{
+
+void free_request(wfp_request * request, ino_t, uint32_t, size_t ,size_t)
+{
+    free(request);
+}
+
+}
+
+TEST(wfp_impl_read, invoke_provider)
+{
+    ino_t inode = 42;
+    uint32_t handle = 5;
+    size_t offset = 2;
+    size_t length = 1;
+    MockProvider provider;
+    EXPECT_CALL(provider, read(_, inode, handle, offset, length)).Times(1)
+        .WillOnce(Invoke(free_request));
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(inode));
+    json_array_append_new(params, json_integer(handle));
+    json_array_append_new(params, json_integer(offset));
+    json_array_append_new(params, json_integer(length));
+
+    wfp_impl_read(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_read, fail_invalid_param_count)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, read(_, _, _, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(1));
+    json_array_append_new(params, json_integer(2));
+    json_array_append_new(params, json_integer(3));
+    json_array_append_new(params, json_integer(4));
+    json_array_append_new(params, json_integer(5));
+
+    wfp_impl_read(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_read, fail_invalid_inode_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, read(_, _, _, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_string("42"));
+    json_array_append_new(params, json_integer(2));
+    json_array_append_new(params, json_integer(3));
+    json_array_append_new(params, json_integer(4));
+
+    wfp_impl_read(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_read, fail_invalid_handle_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, read(_, _, _, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(1));
+    json_array_append_new(params, json_string("42"));
+    json_array_append_new(params, json_integer(3));
+    json_array_append_new(params, json_integer(4));
+
+    wfp_impl_read(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_read, fail_invalid_offset_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, read(_, _, _, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(1));
+    json_array_append_new(params, json_integer(2));
+    json_array_append_new(params, json_string("42"));
+    json_array_append_new(params, json_integer(4));
+
+    wfp_impl_read(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_read, fail_invalid_length_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider, read(_, _, _, _, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(1));
+    json_array_append_new(params, json_integer(2));
+    json_array_append_new(params, json_integer(3));
+    json_array_append_new(params, json_string("42"));
+
+    wfp_impl_read(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_read, default_responds_error)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond_error(_,42)).Times(1);
+
+    wfp_impl_read_default(req, 0, 0, 1, 2, nullptr);
+}
+
+TEST(wfp_impl_read, respond)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(ReadResultMatcher("d2Y=", "base64", 2), 42)).Times(1);
+
+    char const data[] = "wf";
+    wfp_impl_respond_read(req, data, 2);
+}
+
+TEST(wfp_impl_read, respond_empty)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(ReadResultMatcher("", "identity", 0), 42)).Times(1);
+
+    wfp_impl_respond_read(req, nullptr, 0);
+}

test/webfuse_provider/provider/operation/test_readdir.cc

@@ -0,0 +1,100 @@
+#include "webfuse_provider/impl/operation/readdir.h"
+#include "webfuse_provider/mocks/mock_request.hpp"
+#include "webfuse_provider/mocks/mock_provider.hpp"
+#include "webfuse_provider/mocks/fake_invokation_context.hpp"
+#include "webfuse_provider/dirbuffer.h"
+
+#include <gtest/gtest.h>
+#include <cstdlib>
+
+using ::webfuse_test::MockProvider;
+using ::webfuse_test::MockRequest;
+using ::webfuse_test::ReaddirMatcher;
+using ::webfuse_test::create_context;
+using ::testing::_;
+using ::testing::Invoke;
+
+namespace
+{
+
+void free_request(wfp_request * request, ino_t)
+{
+    free(request);
+}
+
+}
+
+TEST(wfp_impl_readdir, invoke_provider)
+{
+    ino_t inode = 23;
+    MockProvider provider;
+    EXPECT_CALL(provider,readdir(_, inode)).Times(1).WillOnce(Invoke(free_request));
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(inode));
+
+    wfp_impl_readdir(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_readdir, fail_invalid_param_count)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,readdir(_, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_integer(1));
+    json_array_append_new(params, json_integer(1));
+
+    wfp_impl_readdir(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_readdir, fail_invalid_inode_type)
+{
+    MockProvider provider;
+    EXPECT_CALL(provider,readdir(_, _)).Times(0);
+
+    wfp_request request = {nullptr, nullptr, 0};
+    wfp_impl_invokation_context context = create_context(provider, &request);
+
+    json_t * params = json_array();
+    json_array_append_new(params, json_string("test.filesystem"));
+    json_array_append_new(params, json_string("1"));
+
+    wfp_impl_readdir(&context, params, 42);
+    json_decref(params);
+}
+
+TEST(wfp_impl_readdir, default_responds_error)
+{
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond_error(_,42)).Times(1);
+
+    wfp_impl_readdir_default(req, 0, nullptr);
+}
+
+TEST(wfp_impl_readdir, respond)
+{
+    char const item0[] = "some.file";
+    char const * items[] = { item0, nullptr };
+
+    MockRequest request;
+    auto * req = request.create_request(42);
+    EXPECT_CALL(request, respond(ReaddirMatcher(items), 42)).Times(1);
+
+    wfp_dirbuffer * buffer = wfp_dirbuffer_create();
+    wfp_dirbuffer_add(buffer, item0, 42);
+    wfp_impl_respond_readdir(req, buffer);
+    wfp_dirbuffer_dispose(buffer);
+
+}