chore(webfuse) Increase test coverage (#34)

* removes unnecessary code * adds test of wf_status * adds tests of wf_message * adds tests of wf_message_queue * changed branch of coverage badge to display correct results * moves core tests into separate subdirectory * increases coverage of timer test * moves adapter specific tests into separate directory * moves provider specific tests into separate directory * adds tests of jsonrpc utilities * adds tests of jsonrpc request * adds test of jsonrpc response * adds tests of jsonrpc server * adds tests of jsonrpc proxy * adds integration test (found some issues) * disables problematic tests * fixes resource leak: pending timer after cleanup proxy * fixes order of cleanup to prevent processing pending requests after filesystem shut down * fixes some memcheck and helgrind errors: initialization of lws_log; setup of client and server * disabled a test * fixes error in msleep utility * fixes deadlock at IntegrationTest using valgrind * removes unit test code from coverage report * adds some integration tests * makes badge show coverage of master * fixes some coding style issues * fixes eary trigger of is_connected (provider) * fixes read error in 32 bit environments\n\ninode is always 64 bit, but variadic wf_impl_jsonrpc_proxy_invoke expects int
2026-03-02 04:09:18 +00:00 · 2019-05-19 14:33:42 +02:00
parent 9180ad3bb7
commit 07e32757f8
49 changed files with 1650 additions and 54 deletions
--- a/test/provider/test_static_filesystem.cc
+++ b/test/provider/test_static_filesystem.cc
@@ -0,0 +1,61 @@
+#include <gtest/gtest.h>
+
+#include "webfuse/provider/impl/static_filesystem.h"
+#include "webfuse/provider/client_config.h"
+#include "webfuse/provider/impl/client_config.h"
+
+#include "mock_request.hpp"
+
+using webfuse_test::request_create;
+using webfuse_test::MockRequest;
+using webfuse_test::GetAttrMatcher;
+using webfuse_test::ReaddirMatcher;
+using testing::_;
+
+TEST(wfp_static_filesystem, has_root_dir)
+{
+    struct wfp_client_config * config = wfp_client_config_create();
+    struct wfp_static_filesystem * filesystem = wfp_impl_static_filesystem_create(config);
+
+    MockRequest mock;
+    struct wfp_request * request = request_create(&mock, 42);
+    EXPECT_CALL(mock, respond(GetAttrMatcher(1, 0555, "dir"), 42)).Times(1);
+
+    config->provider.getattr(request, 1, config->user_data);
+
+    wfp_impl_static_filesystem_dispose(filesystem);
+    wfp_client_config_dispose(config);
+}
+
+TEST(wfp_static_filesystem, contains_default_dirs)
+{
+    struct wfp_client_config * config = wfp_client_config_create();
+    struct wfp_static_filesystem * filesystem = wfp_impl_static_filesystem_create(config);
+
+    MockRequest mock;
+    struct wfp_request * request = request_create(&mock, 23);
+    char const * default_dirs[] = {".", "..", nullptr};
+    EXPECT_CALL(mock, respond(ReaddirMatcher(default_dirs), 23)).Times(1);
+
+    config->provider.readdir(request, 1, config->user_data);
+
+    wfp_impl_static_filesystem_dispose(filesystem);
+    wfp_client_config_dispose(config);
+}
+
+TEST(wfp_static_filesystem, add_text)
+{
+    struct wfp_client_config * config = wfp_client_config_create();
+    struct wfp_static_filesystem * filesystem = wfp_impl_static_filesystem_create(config);
+    wfp_impl_static_filesystem_add_text(filesystem, "text.file", 666, "some text");
+
+    MockRequest mock;
+    struct wfp_request * request = request_create(&mock, 23);
+    char const * contained_elements[] = {"text.file", nullptr};
+    EXPECT_CALL(mock, respond(ReaddirMatcher(contained_elements), 23)).Times(1);
+
+    config->provider.readdir(request, 1, config->user_data);
+
+    wfp_impl_static_filesystem_dispose(filesystem);
+    wfp_client_config_dispose(config);
+}
--- a/test/provider/test_url.cc
+++ b/test/provider/test_url.cc
@@ -0,0 +1,92 @@
+#include <gtest/gtest.h>
+
+#include "webfuse/provider/impl/url.h"
+
+TEST(url, ParseWs)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "ws://localhost/");
+    ASSERT_TRUE(result);
+    ASSERT_EQ(80, url.port);
+    ASSERT_FALSE(url.use_tls);
+    ASSERT_STREQ("localhost", url.host);
+    ASSERT_STREQ("/", url.path);
+
+    wfp_impl_url_cleanup(&url);
+}
+
+TEST(url, ParswWss)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "wss://localhost/");
+    ASSERT_TRUE(result);
+    ASSERT_EQ(443, url.port);
+    ASSERT_TRUE(url.use_tls);
+    ASSERT_STREQ("localhost", url.host);
+    ASSERT_STREQ("/", url.path);
+
+    wfp_impl_url_cleanup(&url);
+}
+
+TEST(url, ParseIPAdress)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "ws://127.0.0.1/");
+    ASSERT_TRUE(result);
+    ASSERT_EQ(80, url.port);
+    ASSERT_STREQ("127.0.0.1", url.host);
+    ASSERT_STREQ("/", url.path);
+
+    wfp_impl_url_cleanup(&url);
+}
+
+TEST(url, ParsePort)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "ws://localhost:54321/");
+    ASSERT_TRUE(result);
+    ASSERT_EQ(54321, url.port);
+
+    wfp_impl_url_cleanup(&url);
+}
+
+TEST(url, ParseNonEmptyPath)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "ws://localhost/some_path?query");
+    ASSERT_TRUE(result);
+    ASSERT_STREQ("/some_path?query", url.path);
+
+    wfp_impl_url_cleanup(&url);
+}
+
+TEST(url, FailToParseUnknownProtocol)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "unknown://localhost/");
+    ASSERT_FALSE(result);
+    ASSERT_EQ(0, url.port);
+    ASSERT_EQ(nullptr, url.path);
+    ASSERT_EQ(nullptr, url.host);
+}
+
+TEST(url, FailToParseMissingProtocol)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "unknown");
+    ASSERT_FALSE(result);
+    ASSERT_EQ(0, url.port);
+    ASSERT_EQ(nullptr, url.path);
+    ASSERT_EQ(nullptr, url.host);
+}
+
+TEST(url, FailToParseMissingPath)
+{
+    struct wfp_impl_url url;
+    bool result = wfp_impl_url_init(&url, "ws://localhost");
+    ASSERT_FALSE(result);
+    ASSERT_EQ(0, url.port);
+    ASSERT_EQ(nullptr, url.path);
+    ASSERT_EQ(nullptr, url.host);
+}
+