Mention running lint rules, conform commit to lint rules

pull/276/head
Robert Sandell 6 years ago
parent 97d877f9c2
commit cce6430647

@ -132,6 +132,7 @@ If you'd like to contribute a change to bowser, modify the files in `src/`, then
``` sh ``` sh
$ npm install #build $ npm install #build
$ npm test #run tests $ npm test #run tests
$ npm run lint #check lint rules
``` ```
### Adding tests ### Adding tests

@ -76,24 +76,22 @@ class Utils {
* @return {string} versionName * @return {string} versionName
*/ */
static getAndroidVersionName(version) { static getAndroidVersionName(version) {
const v = version.split('.').splice(0, 2).map((s) => { const v = version.split('.').splice(0, 2).map(s => parseInt(s, 10) || 0);
return parseInt(s, 10) || 0;
});
v.push(0); v.push(0);
if (v[0] === 1 && v[1] < 5) return undefined; if (v[0] === 1 && v[1] < 5) return undefined;
if (v[0] === 1 && v[1] < 6) return "Cupcake"; if (v[0] === 1 && v[1] < 6) return 'Cupcake';
if (v[0] === 1 && v[1] >= 6) return "Donut"; if (v[0] === 1 && v[1] >= 6) return 'Donut';
if (v[0] === 2 && v[1] < 2) return "Eclair"; if (v[0] === 2 && v[1] < 2) return 'Eclair';
if (v[0] === 2 && v[1] === 2) return "Froyo"; if (v[0] === 2 && v[1] === 2) return 'Froyo';
if (v[0] === 2 && v[1] > 2) return "Gingerbread"; if (v[0] === 2 && v[1] > 2) return 'Gingerbread';
if (v[0] === 3) return "Honeycomb"; if (v[0] === 3) return 'Honeycomb';
if (v[0] === 4 && v[1] < 1) return "Ice Cream Sandwich"; if (v[0] === 4 && v[1] < 1) return 'Ice Cream Sandwich';
if (v[0] === 4 && v[1] < 4) return "Jelly Bean"; if (v[0] === 4 && v[1] < 4) return 'Jelly Bean';
if (v[0] === 4 && v[1] >= 4) return "KitKat"; if (v[0] === 4 && v[1] >= 4) return 'KitKat';
if (v[0] === 5) return "Lollipop"; if (v[0] === 5) return 'Lollipop';
if (v[0] === 6) return "Marshmallow"; if (v[0] === 6) return 'Marshmallow';
if (v[0] === 7) return "Nougat"; if (v[0] === 7) return 'Nougat';
if (v[0] === 8) return "Oreo"; if (v[0] === 8) return 'Oreo';
return undefined; return undefined;
} }

Loading…
Cancel
Save