Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2024-10-27 20:34:22 +00:00
Code Issues Releases Wiki Activity

Fix tests after changes

Browse Source
This commit is contained in:
Denis Demchenko 2018-07-05 22:58:14 +03:00
parent 1f572ed8f4
commit c79b71736e
4 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bowser.js
View File

@ -40,7 +40,7 @@ class Bowser {
* @return {ParsedResult} * @return {ParsedResult}
*/ */
static parse(UA) { static parse(UA) {
return (new Bowser(UA)).getResult(); return (new Parser(UA)).getResult();
} }
} }

1
src/utils.js
View File

@ -78,6 +78,7 @@ class Utils {
* @return {Number} comparison result: -1 when versionA is lower, * @return {Number} comparison result: -1 when versionA is lower,
* 1 when versionA is bigger, 0 when both equal * 1 when versionA is bigger, 0 when both equal
*/ */
/* eslint consistent-return: 1 */
static compareVersions(versionA, versionB) { static compareVersions(versionA, versionB) {
// 1) get common precision for both versions, for example for "10.0" and "9" it should be 2 // 1) get common precision for both versions, for example for "10.0" and "9" it should be 2
let precision = Math.max( let precision = Math.max(

2
test/acceptance/test-list-of-ua.js
View File

@ -10,7 +10,7 @@ const browserNames = Object.keys(listOfUA);
browserNames.forEach((browserName) => { browserNames.forEach((browserName) => {
listOfUA[browserName].forEach((browser) => { listOfUA[browserName].forEach((browser) => {
test('Check all the test browsers', (t) => { test('Check all the test browsers', (t) => {
const parsed = new Bowser(browser.ua).parse().getResult(); const parsed = Bowser.parse(browser.ua);
t.deepEqual(parsed, browser.spec, `${browser.ua}`); t.deepEqual(parsed, browser.spec, `${browser.ua}`);
t.is(parsed.browser.name, browserName, `${browser.ua}`); t.is(parsed.browser.name, browserName, `${browser.ua}`);
}); });

4
test/unit/bowser.js
View File

@ -3,14 +3,14 @@ import Bowser from '../../src/bowser';
import Parser from '../../src/parser'; import Parser from '../../src/parser';
const UA = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 OPR/43.0.2442.1165'; const UA = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 OPR/43.0.2442.1165';
const browser = new Bowser(UA); const browser = Bowser.getParser(UA);
test('Bowser`s constructor returns a Parser instance', (t) => { test('Bowser`s constructor returns a Parser instance', (t) => {
t.truthy(browser instanceof Parser); t.truthy(browser instanceof Parser);
}); });
test('Bowser`s constructor fails if UA is empty', (t) => { test('Bowser`s constructor fails if UA is empty', (t) => {
t.throws(() => (new Bowser())); t.throws(() => (Bowser.getParser()));
}); });
test('Bowser.parse parses UA and returns result', (t) => { test('Bowser.parse parses UA and returns result', (t) => {