Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2025-12-05 06:02:14 +00:00
Code Issues Releases Wiki Activity

Address review feedback: add tests, remove comments, revert package-lock changes

Browse Source 
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-08-09 21:17:01 +00:00
parent 4a0861a02c
commit b0877ffd5f
3 changed files with 7790 additions and 10467 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18233
package-lock.json generated
View File

File diff suppressed because it is too large Load Diff

1
src/bowser.js
View File

@ -76,7 +76,6 @@ class Bowser {
export default Bowser; export default Bowser;
// Named exports for tree shaking
export const { getParser } = Bowser; export const { getParser } = Bowser;
export const { parse } = Bowser; export const { parse } = Bowser;
export { export {

23
test/unit/bowser.js
View File

@ -1,5 +1,5 @@
import test from 'ava'; import test from 'ava';
import Bowser from '../../src/bowser'; import Bowser, { getParser, parse, BROWSER_MAP, ENGINE_MAP, OS_MAP, PLATFORMS_MAP } from '../../src/bowser';
import Parser from '../../src/parser'; import Parser from '../../src/parser';
const UA = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 OPR/43.0.2442.1165'; const UA = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 OPR/43.0.2442.1165';
@ -16,3 +16,24 @@ test('Bowser`s constructor fails if UA is empty', (t) => {
test('Bowser.parse parses UA and returns result', (t) => { test('Bowser.parse parses UA and returns result', (t) => {
t.deepEqual(Bowser.parse(UA), browser.getResult()); t.deepEqual(Bowser.parse(UA), browser.getResult());
}); });
test('Named export getParser works like Bowser.getParser', (t) => {
const namedExportParser = getParser(UA);
t.truthy(namedExportParser instanceof Parser);
t.deepEqual(namedExportParser.getResult(), browser.getResult());
});
test('Named export parse works like Bowser.parse', (t) => {
t.deepEqual(parse(UA), Bowser.parse(UA));
});
test('Named exports of constants are available', (t) => {
t.truthy(BROWSER_MAP);
t.truthy(ENGINE_MAP);
t.truthy(OS_MAP);
t.truthy(PLATFORMS_MAP);
t.is(BROWSER_MAP, Bowser.BROWSER_MAP);
t.is(ENGINE_MAP, Bowser.ENGINE_MAP);
t.is(OS_MAP, Bowser.OS_MAP);
t.is(PLATFORMS_MAP, Bowser.PLATFORMS_MAP);
});