Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2026-10-08 03:41:50 +00:00
Code Issues Releases Wiki Activity

Validate Android WebView detection with Client Hints brands

Browse Source 
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-03-14 15:00:10 +00:00
parent 7307dc6892
commit 37903d2f58
2 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/parser-browsers.js
View File

@@ -1095,12 +1095,28 @@ const browsersList = [
/* Android WebView */ /* Android WebView */
{ {
test(parser) { test(parser) {
// Client Hints: check for 'Android WebView' brand (Chromium-based WebViews)
if (parser.hasBrand('Android WebView')) {
return true;
}
// UA fallback: the canonical '; wv)' marker in Android WebView UA strings
return parser.test(/android/i) && parser.test(/; wv\)/i); return parser.test(/android/i) && parser.test(/; wv\)/i);
}, },
describe(ua) { describe(ua, parser) {
const browser = { const browser = {
name: 'Chrome WebView', name: 'Chrome WebView',
}; };
// Try Client Hints brand version first
if (parser) {
const hintsVersion = parser.getBrandVersion('Android WebView');
if (hintsVersion) {
browser.version = hintsVersion;
return browser;
}
}
// Fall back to Chrome version from UA string
const version = Utils.getFirstMatch(/(?:chrome|crios|crmo)\/(\d+(\.?_?\d+)+)/i, ua); const version = Utils.getFirstMatch(/(?:chrome|crios|crmo)\/(\d+(\.?_?\d+)+)/i, ua);
if (version) { if (version) {

34
test/unit/parser.js
View File

@@ -449,3 +449,37 @@ test('Parser.getBrandVersion returns version for Vivaldi', (t) => {
const p = new Parser(VIVALDI_UA, false, VIVALDI_HINTS); const p = new Parser(VIVALDI_UA, false, VIVALDI_HINTS);
t.is(p.getBrandVersion('Vivaldi'), '7.1'); t.is(p.getBrandVersion('Vivaldi'), '7.1');
}); });
const ANDROID_WEBVIEW_UA = 'Mozilla/5.0 (Linux; Android 5.1.1; Nexus 5 Build/LMY48B; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/43.0.2357.65 Mobile Safari/537.36';
const ANDROID_WEBVIEW_HINTS = {
brands: [
{ brand: 'Android WebView', version: '131' },
{ brand: 'Chromium', version: '131' },
{ brand: 'Not_A Brand', version: '24' },
],
mobile: true,
platform: 'Android',
platformVersion: '5.1.1',
};
test('Parser detects Chrome WebView from client hints brands', (t) => {
const p = new Parser(ANDROID_WEBVIEW_UA, false, ANDROID_WEBVIEW_HINTS);
t.is(p.getBrowserName(), 'Chrome WebView');
t.is(p.getBrowserVersion(), '131');
});
test('Parser detects Chrome WebView from UA string without client hints', (t) => {
const p = new Parser(ANDROID_WEBVIEW_UA);
t.is(p.getBrowserName(), 'Chrome WebView');
t.is(p.getBrowserVersion(), '43.0.2357.65');
});
test('Parser.hasBrand detects Android WebView', (t) => {
const p = new Parser(ANDROID_WEBVIEW_UA, false, ANDROID_WEBVIEW_HINTS);
t.true(p.hasBrand('Android WebView'));
});
test('Parser.getBrandVersion returns version for Android WebView', (t) => {
const p = new Parser(ANDROID_WEBVIEW_UA, false, ANDROID_WEBVIEW_HINTS);
t.is(p.getBrandVersion('Android WebView'), '131');
});