gristlabs_grist-core/app/client/aclui
Dmitry S 5deac68315 (core) Update ACL resources/rules when tables/columns get renamed
Summary:
- Placed rule-updating functions in acl.py.
- Reset UI when rules update externally, or alert the user to reset if there
  are pending local changes.
- Removed some unused and distracting bits from client-side DocModel.

A few improvements related to poor error handling:
- In case of missing DocActions (tickled by broken ACL rule handling), don't
  add to confusion by attempting to process bad actions
- In case of missing attributes in ACL formulas, return undefined rather than
  fail; the latter creates more problems.
- In case in invalid rules, fail rather than skip; this feels more correct now
  that we have error checking and recovery option, and helps avoid invalid rules.
- Prevent saving invalid rules with an empty ACL formula.
- Fix bug with rule positions.

Test Plan: Added a python and browser test for table/column renames.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2698
2021-01-04 22:03:01 -05:00
..
AccessRules.ts (core) Update ACL resources/rules when tables/columns get renamed 2021-01-04 22:03:01 -05:00
ACLColumnList.ts (core) One more phase of ACL UI revision. 2020-12-22 22:18:12 -05:00
ACLFormulaEditor.ts (core) One more phase of ACL UI revision. 2020-12-22 22:18:12 -05:00
ACLSelect.ts (core) One more phase of ACL UI revision. 2020-12-22 22:18:12 -05:00
PermissionsWidget.ts (core) One more phase of ACL UI revision. 2020-12-22 22:18:12 -05:00