gristlabs_grist-core/app/client
Dmitry S fc44a60edf (core) When reporting email in log metadata, use normalized email.
Summary:
There has been inconsistency in using display email vs normalized email, which
ends up creating some duplication in downstream analyses (e.g. the same user
showing up twice with different capitalization).

1. Add UserProfile.loginEmail field with normalized email to prefer, when set, over the inconsistently used UserProfile.email.
2. In one place where it's not available, normalize the display email manually.
3. Clean up some code in Client.ts.

Unrelated tweak to API Console to be clear when a URL parameter wasn't found (rather than show whatever happens to be the first value).

Several test robustness improvements:
- Misplaced parenthesis in gristWebDriverUtils has been causing optTimeout argument to be ignored in tests, and treated always as indefinite.
- Attempt to fix SortMenu test by ignoring (retrying with logging) errors in waitForServer, which include "script timeout" errors that come from a non-configurable selenium or chromedriver timeout.
- Attempt to improve onNewTab() helper, which plays a role in failing Billing tests.

Test Plan: Tested manually the capitalization of logged emails. Counting on existing tests to catch issues.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D4188
2024-02-15 10:49:01 -05:00
..
aclui (core) Forms post-release fixes and improvements 2024-02-14 16:38:16 -05:00
components (core) Forms post-release fixes and improvements 2024-02-14 16:38:16 -05:00
lib (core) Improve API Console and link from Document Settings. 2024-01-29 10:08:19 -05:00
models (core) Forms post-release fixes and improvements 2024-02-14 16:38:16 -05:00
ui (core) Forms post-release fixes and improvements 2024-02-14 16:38:16 -05:00
ui2018 (core) Hide top bar items to left of search while open 2024-02-11 15:48:12 -05:00
widgets (core) Forms post-release fixes and improvements 2024-02-14 16:38:16 -05:00
apiconsole.ts (core) When reporting email in log metadata, use normalized email. 2024-02-15 10:49:01 -05:00
app.css (core) Polish tutorial popups 2023-04-20 12:20:03 -04:00
app.js (core) Improve API Console and link from Document Settings. 2024-01-29 10:08:19 -05:00
billingMain.ts (core) Polish forms 2024-01-24 02:18:03 -08:00
browserCheck.ts (core) On mobile, only show a warning for older and unknown browsers rather than for all 2023-06-01 11:15:21 -04:00
declarations.d.ts (core) Reference and ReferenceList should trigger RightMenu to show up on Column tab and display reference toolitp, if it wasn't dismissed yet 2024-02-13 16:59:59 +01:00
DefaultHooks.ts add hooks for tweaking how downloads happen (for grist-static) (#665) 2023-09-09 14:50:32 -04:00
errorMain.ts (core) Polish forms 2024-01-24 02:18:03 -08:00
exposeModulesForTests.js (core) Improve API Console and link from Document Settings. 2024-01-29 10:08:19 -05:00
Hooks.ts support other SQLite wrappers, and various hooks needed by grist-static (#516) 2023-05-23 15:17:28 -04:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json (core) Migrate to SRP and add change password dialog 2022-03-16 21:35:06 -07:00