Alex Hall 225a76c9cb (core) Don't throw error in onRecord(s) for insufficient access for includeColumns ... Summary: This removes checking for full access in `onRecord/onRecords` when `includeColumns` is a non-default value. The check had two problems: 1. It relied on the access level being present in the URL query parameters, which doesn't work if the page has redirected. See the discussion in https://grist.slack.com/archives/C0234CPPXPA/p1702576602615509. There seems to be no way to reliably and synchronously check the access level. 2. Calling `onRecords` before `ready` and forgetting to handle an error from the access check meant that `ready` wouldn't be called, so Grist couldn't request the correct access level from the user. I made this mistake and it seems like a nasty footgun. Ultimately this has no effect on security, as an error will still be raised, but in a place where the widget developer can't catch it. They'll still see an error message in the console, and they can still check the access level reliably using `onOptions`, so I think this is OK. Test Plan: Updated nbrowser test Reviewers: georgegevoian, paulfitz Reviewed By: georgegevoian, paulfitz Differential Revision: https://phab.getgrist.com/D4145		2023-12-30 10:16:40 +02:00
..
client	(core) Don't throw error in onRecord(s) for insufficient access for includeColumns	2023-12-30 10:16:40 +02:00
common	(core) Forms feature	2023-12-20 13:23:12 +01:00
gen-server	(core) move apiserver tests to core, disentangling notifier+billing parts	2023-12-26 08:43:12 -05:00
plugin	(core) Don't throw error in onRecord(s) for insufficient access for includeColumns	2023-12-30 10:16:40 +02:00
server	(core) API console	2023-12-27 22:02:30 +02:00
tsconfig.json	(core) move home server into core	2020-07-21 20:39:10 -04:00