mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
b6dd066b7f
Summary: For Windows and Ubuntu (on chrome) texteditor was showing scrollbars for very long words. Adding more space to fix this issue. Test Plan: manual Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3122
152 lines
5.8 KiB
TypeScript
152 lines
5.8 KiB
TypeScript
/**
|
|
* This is a copy of TextEditor.js, converted to typescript.
|
|
*/
|
|
import {createGroup} from 'app/client/components/commands';
|
|
import {testId} from 'app/client/ui2018/cssVars';
|
|
import {createMobileButtons, getButtonMargins} from 'app/client/widgets/EditorButtons';
|
|
import {EditorPlacement, ISize} from 'app/client/widgets/EditorPlacement';
|
|
import {NewBaseEditor, Options} from 'app/client/widgets/NewBaseEditor';
|
|
import {CellValue} from "app/common/DocActions";
|
|
import {undef} from 'app/common/gutil';
|
|
import {dom, Observable} from 'grainjs';
|
|
|
|
export class NTextEditor extends NewBaseEditor {
|
|
// Observable with current editor state (used by drafts or latest edit/position component)
|
|
public readonly editorState: Observable<string>;
|
|
|
|
protected cellEditorDiv: HTMLElement;
|
|
protected textInput: HTMLTextAreaElement;
|
|
protected commandGroup: any;
|
|
|
|
private _dom: HTMLElement;
|
|
private _editorPlacement: EditorPlacement;
|
|
private _contentSizer: HTMLElement;
|
|
private _alignment: string;
|
|
|
|
// Note: TextEditor supports also options.placeholder for use by derived classes, but this is
|
|
// easy to apply to this.textInput without needing a separate option.
|
|
constructor(options: Options) {
|
|
super(options);
|
|
|
|
const initialValue: string = undef(
|
|
options.state as string | undefined,
|
|
options.editValue, String(options.cellValue ?? ""));
|
|
this.editorState = Observable.create<string>(this, initialValue);
|
|
|
|
this.commandGroup = this.autoDispose(createGroup(options.commands, null, true));
|
|
this._alignment = options.field.widgetOptionsJson.peek().alignment || 'left';
|
|
this._dom =
|
|
dom('div.default_editor',
|
|
// add readonly class
|
|
dom.cls("readonly_editor", options.readonly),
|
|
this.cellEditorDiv = dom('div.celleditor_cursor_editor',
|
|
testId('widget-text-editor'),
|
|
this._contentSizer = dom('div.celleditor_content_measure'),
|
|
this.textInput = dom('textarea',
|
|
dom.cls('celleditor_text_editor'),
|
|
dom.style('text-align', this._alignment),
|
|
dom.prop('value', initialValue),
|
|
dom.boolAttr('readonly', options.readonly),
|
|
this.commandGroup.attach(),
|
|
dom.on('input', () => this.onInput())
|
|
)
|
|
),
|
|
createMobileButtons(options.commands),
|
|
);
|
|
}
|
|
|
|
public attach(cellElem: Element): void {
|
|
// Attach the editor dom to page DOM.
|
|
this._editorPlacement = EditorPlacement.create(this, this._dom, cellElem, {margins: getButtonMargins()});
|
|
|
|
// Reposition the editor if needed for external reasons (in practice, window resize).
|
|
this.autoDispose(this._editorPlacement.onReposition.addListener(this.resizeInput, this));
|
|
|
|
this.setSizerLimits();
|
|
|
|
// Once the editor is attached to DOM, resize it to content, focus, and set cursor.
|
|
this.resizeInput();
|
|
this.textInput.focus();
|
|
const pos = Math.min(this.options.cursorPos, this.textInput.value.length);
|
|
this.textInput.setSelectionRange(pos, pos);
|
|
}
|
|
|
|
public getDom(): HTMLElement {
|
|
return this._dom;
|
|
}
|
|
|
|
public getCellValue(): CellValue {
|
|
const valueParser = this.options.field.valueParser.peek();
|
|
return valueParser(this.getTextValue());
|
|
}
|
|
|
|
public getTextValue() {
|
|
return this.textInput.value;
|
|
}
|
|
|
|
public getCursorPos() {
|
|
return this.textInput.selectionStart;
|
|
}
|
|
|
|
public setSizerLimits() {
|
|
// Set the max width of the sizer to the max we could possibly grow to, so that it knows to wrap
|
|
// once we reach it.
|
|
const maxSize = this._editorPlacement.calcSizeWithPadding(this.textInput,
|
|
{width: Infinity, height: Infinity}, {calcOnly: true});
|
|
this._contentSizer.style.maxWidth = Math.ceil(maxSize.width) + 'px';
|
|
}
|
|
|
|
/**
|
|
* Occurs when user types text in the textarea
|
|
*
|
|
*/
|
|
protected onInput() {
|
|
// Resize the textbox whenever user types in it.
|
|
this.resizeInput();
|
|
|
|
// notify about current state
|
|
this.editorState.set(String(this.getTextValue()));
|
|
}
|
|
|
|
/**
|
|
* Helper which resizes textInput to match its content. It relies on having a contentSizer element
|
|
* with the same font/size settings as the textInput, and on having `calcSize` helper,
|
|
* which is provided by the EditorPlacement class.
|
|
*/
|
|
protected resizeInput() {
|
|
const textInput = this.textInput;
|
|
// \u200B is a zero-width space; it is used so the textbox will expand vertically
|
|
// on newlines, but it does not add any width.
|
|
this._contentSizer.textContent = textInput.value + '\u200B';
|
|
const rect = this._contentSizer.getBoundingClientRect();
|
|
|
|
// Allow for a bit of extra space after the cursor (only desirable when text is left-aligned).
|
|
if (this._alignment === "left") {
|
|
// Modifiable in modern browsers: https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect
|
|
rect.width += 16;
|
|
}
|
|
|
|
const size = this._editorPlacement.calcSizeWithPadding(textInput, rect);
|
|
textInput.style.width = size.width + 'px';
|
|
textInput.style.height = size.height + 'px';
|
|
|
|
// Scrollbars are first visible (as the content get larger), but resizing should hide them (if there is enough
|
|
// space), but this doesn't work in Chrome on Windows or Ubuntu (but works on Mac). Here if scrollbars are visible,
|
|
// but we got same enough spaces, we will force browser to check the available space once more time.
|
|
if (enoughSpace(rect, size) && hasScroll(textInput)) {
|
|
textInput.style.overflow = "hidden";
|
|
textInput.clientHeight; // just access metrics is enough to repaint
|
|
textInput.style.overflow = "auto";
|
|
}
|
|
}
|
|
}
|
|
|
|
function enoughSpace(requested: ISize, received: ISize) {
|
|
return requested.width <= received.width && requested.height <= received.height;
|
|
}
|
|
|
|
function hasScroll(el: HTMLTextAreaElement) {
|
|
// This is simple check for dimensions, scrollbar will appear when scrollHeight > clientHeight
|
|
return el.scrollHeight > el.clientHeight || el.scrollWidth > el.clientWidth;
|
|
}
|