mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
c714d09eb8
Summary: We do not support to show non numeric column as chart series. However we didn't prevent the user from doing it and it could cause unexpected behaviour such as a missing chart. This diff addresses that issue by doing two following thing: 1) it prevents user from adding non numeric column as series and 2) it makes sure that if there is a non numeric series it does not mess up the chart (it still can happen that a non numeric series ends up in charts even with 1) for instance if users convert a series' column to a non numeric column for instance). Links to UI discussion: - https://grist.quip.com/wb4gAgrQM2aP#TZEADAKPs8n - https://grist.quip.com/wb4gAgrQM2aP#TZEADAP8S8N Test Plan: - new behaviour covered in nbrowser/ChartView3.ts - Some test were using non-numeric column as series, diff fixes that to. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3206