mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 16:10:49 +00:00
fc44a60edf
Summary: There has been inconsistency in using display email vs normalized email, which ends up creating some duplication in downstream analyses (e.g. the same user showing up twice with different capitalization). 1. Add UserProfile.loginEmail field with normalized email to prefer, when set, over the inconsistently used UserProfile.email. 2. In one place where it's not available, normalize the display email manually. 3. Clean up some code in Client.ts. Unrelated tweak to API Console to be clear when a URL parameter wasn't found (rather than show whatever happens to be the first value). Several test robustness improvements: - Misplaced parenthesis in gristWebDriverUtils has been causing optTimeout argument to be ignored in tests, and treated always as indefinite. - Attempt to fix SortMenu test by ignoring (retrying with logging) errors in waitForServer, which include "script timeout" errors that come from a non-configurable selenium or chromedriver timeout. - Attempt to improve onNewTab() helper, which plays a role in failing Billing tests. Test Plan: Tested manually the capitalization of logged emails. Counting on existing tests to catch issues. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D4188
37 lines
1.5 KiB
TypeScript
37 lines
1.5 KiB
TypeScript
import {UserPrefs} from 'app/common/Prefs';
|
|
|
|
// User profile info for the user. When using Cognito, it is fetched during login.
|
|
export interface UserProfile {
|
|
email: string; // TODO: Used inconsistently: as lowercase login email or display email.
|
|
loginEmail?: string; // When set, this is consistently normalized (lowercase) login email.
|
|
name: string;
|
|
picture?: string|null; // when present, a url to a public image of unspecified dimensions.
|
|
anonymous?: boolean; // when present, asserts whether user is anonymous (not authorized).
|
|
connectId?: string|null, // used by GristConnect to identify user in external provider.
|
|
loginMethod?: 'Google'|'Email + Password'|'External';
|
|
locale?: string|null;
|
|
}
|
|
|
|
// User profile including user id and user ref. All information in it should
|
|
// have been validated against database.
|
|
export interface FullUser extends UserProfile {
|
|
id: number;
|
|
ref?: string|null; // Not filled for anonymous users.
|
|
allowGoogleLogin?: boolean; // when present, specifies whether logging in via Google is possible.
|
|
isSupport?: boolean; // set if user is a special support user.
|
|
prefs?: UserPrefs;
|
|
}
|
|
|
|
export interface LoginSessionAPI {
|
|
/**
|
|
* Logs out by clearing all data in the session store besides the session cookie itself.
|
|
* Broadcasts the logged out state to all clients.
|
|
*/
|
|
logout(): Promise<void>;
|
|
|
|
/**
|
|
* Replaces the user profile object in the session and broadcasts the new profile to all clients.
|
|
*/
|
|
updateProfile(profile: UserProfile): Promise<void>;
|
|
}
|