Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
c1de16aee7
gristlabs_grist-core/app/client/ui
History
Alex Hall c470c4041b (core) Use visibleCol instead of displayCol with createFormatter 
Summary:
Some things (like rendering cells) use the `visibleCol` for `createFormatter`, while other things (like `CopySelection`) used the `displayCol`. For references, the display column has type Any and doesn't know about the original formatting. This resulted in formatting being lost when copying from reference columns even though formatting was preserved when copying from the original (visible) column which looked identical. This diff fixes this and ensures that `createFormatter` is always used with the `visibleCol`. This was agreed on in https://grist.slack.com/archives/C0234CPPXPA/p1639571321043000

Additionally:

- Replaces the functions `createVisibleColFormatter` computed properties `visibleColFormatter` as suggested by a `TODO`.
- Extracts common code from `createVisibleColFormatter` in `ColumnRec` and `ViewFieldRec`

Test Plan: Fixed a test in CopyPaste which displayed the previous inconsistent behaviour.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3189
2021-12-16 22:19:36 +02:00
..
AccountWidget.ts (core) Add additional org items to AppHeader 2021-11-05 08:19:51 -07:00
AddNewButton.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
ApiKey.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
App.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
App.ts (core) Adding import from google drive to the home screen 2021-08-05 20:46:11 +02:00
AppHeader.ts (core) Add additional org items to AppHeader 2021-11-05 08:19:51 -07:00
AppUI.ts (core) Add additional org items to AppHeader 2021-11-05 08:19:51 -07:00
BillingForm.ts (core) Add some polish to the billing page, particularly for sign-up. 2021-11-04 14:23:53 -04:00
BillingPage.ts (core) Add some polish to the billing page, particularly for sign-up. 2021-11-04 14:23:53 -04:00
BillingPageCss.ts (core) add a way to change subdomain in billing pages 2021-08-19 21:22:41 -04:00
BillingPlanManagers.ts (core) Implement DiscourseConnect to enable easy sign-in to community forum 2021-10-01 11:24:22 -04:00
BottomBar.ts (core) Making side bars a bit more usable for narrow screen 2021-01-19 15:22:01 +01:00
buttons.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
CodeHighlight.ts (core) Update UI for formula and column label/id in the right-side panel. 2021-03-17 01:35:56 -04:00
ColumnFilterMenu.ts (core) Use visibleCol instead of displayCol with createFormatter 2021-12-16 22:19:36 +02:00
CustomSectionConfig.ts (core) Exposing custom widgets on the UI 2021-12-01 18:21:06 +01:00
CustomThemes.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
DocHistory.ts (core) Fix JS error when switching from DocHistory to ActionLog too quickly. 2020-12-11 14:33:29 -05:00
DocMenu.ts (core) Update grainjs, fix some code affected by stronger types. 2021-12-07 17:31:03 -05:00
DocMenuCss.ts (core) Site Switcher and Other Sites 2021-08-18 11:24:41 -07:00
DocTour.ts (core) Use auto popup placement for DocTour on mobile 2021-12-16 16:06:15 +02:00
Document.css (core) move client code to core 2020-10-02 13:24:21 -04:00
DocumentSettings.ts (core) mark engine setting as experimental 2021-11-04 20:17:24 -04:00
errorPages.ts (core) Site Switcher and Other Sites 2021-08-18 11:24:41 -07:00
ExampleCard.ts (core) Polish UI/UX of onboarding popups 2021-07-30 15:44:18 +02:00
ExampleInfo.ts (core) Redesign examples and templates UI 2021-07-28 12:29:03 -07:00
FieldConfig.ts (core) Fix "Column Label and ID" widget to avoid getting truncated on some browsers 2021-12-06 10:21:10 -05:00
FieldMenus.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
FileDialog.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
FilterBar.ts (core) Allow filtering hidden columns 2021-11-22 10:26:08 -08:00
forms.ts (core) In Welcome questionnaire, add 'School' option, ask to enter company or school 2020-11-02 14:05:31 -05:00
googleAuth.ts (core) Extending Google Drive integration scope 2021-10-01 10:47:12 +02:00
GridOptions.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
GridViewMenus.ts (core) Adding sort options for columns. 2021-11-03 15:31:39 +01:00
HomeImports.ts (core) Adding import from google drive to the home screen 2021-08-05 20:46:11 +02:00
HomeIntro.ts (core) Redesign examples and templates UI 2021-07-28 12:29:03 -07:00
HomeLeftPane.ts (core) Disabling plugin import sources menu options when import is disabled 2021-08-09 16:54:12 +02:00
LeftPanelCommon.ts (core) Update HelpScout beacon to work with embedded documentation articles. 2021-12-09 22:22:55 -05:00
MakeCopyMenu.ts (core) Error message on Duplicate Document 2021-11-09 19:12:57 +01:00
MenuToggle.ts (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
modals.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
mouseDrag.ts (core) Add our very own implementation of tokenfield (aka pillbox, tag list) 2021-05-03 17:16:24 -04:00
MultiSelector.ts (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
NotifyUI.ts (core) Update HelpScout beacon to work with embedded documentation articles. 2021-12-09 22:22:55 -05:00
OnBoardingPopups.ts (core) Enable auto triggering of Welcome Tour, and various improvements. 2021-07-30 14:17:54 -04:00
PagePanels.ts (core) Brings welcome tour and hide behind a flag 2021-07-19 16:30:53 +02:00
Pages.ts (core) When hidden pages are present in the page list, allow removing them 2021-10-05 15:39:42 -04:00
PageWidgetPicker.ts (core) When changing a table for a page widget, unset widget-linking to avoid invalid values. 2021-08-25 12:53:46 -04:00
PinnedDocs.ts (core) Fix staging test and tweak template line height 2021-07-29 08:16:19 -07:00
ProfileDialog.ts (core) Make ProfileDialog wait consistently for work to finish before closing. 2021-10-13 16:30:43 -04:00
resizeHandle.ts Initial config with a few files that build on client and server side. 2020-05-20 00:50:46 -04:00
RightPanel.ts (core) Update grainjs, fix some code affected by stronger types. 2021-12-07 17:31:03 -05:00
RowContextMenu.ts (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
selectBy.ts (core) Add other direction of linking by reflist 2021-08-30 17:39:15 +02:00
sendToDrive.ts (core) Extending Google Drive integration scope 2021-10-01 10:47:12 +02:00
shadowScroll.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
ShareMenu.ts (core) annotate shares listed in UserManager for documents 2021-10-25 14:29:19 -04:00
SiteSwitcher.ts (core) Add additional org items to AppHeader 2021-11-05 08:19:51 -07:00
TemplateDocs.ts (core) Redesign examples and templates UI 2021-07-28 12:29:03 -07:00
Tools.ts (core) open documents without blocking on data engine 2021-10-01 10:18:56 -04:00
tooltips.ts (core) Draft cells 2021-05-25 21:14:49 +02:00
TopBar.ts (core) Hide workspace in breadcrumbs if doc is unsaved 2021-08-05 15:57:03 -07:00
TopBarCss.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
transientInput.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
transitions.ts (core) Show a welcome card when a user opens an example for the first time. 2020-09-09 23:08:50 -04:00
TreeViewComponent.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
TreeViewComponentCss.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
TriggerFormulas.ts (core) Formula UI redesign 2021-11-05 13:07:30 +01:00
UserImage.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
UserItem.ts (core) annotate shares listed in UserManager for documents 2021-10-25 14:29:19 -04:00
UserManager.ts (core) Show ACL link in UserManager conditionally 2021-11-17 08:43:14 -08:00
ViewLayoutMenu.ts (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
viewport.ts (core) Make mobile the default mode. 2021-02-25 11:31:43 -05:00
ViewSectionMenu.ts (core) Allow filtering hidden columns 2021-11-22 10:26:08 -08:00
VisibleFieldsConfig.ts (core) Fix y-axis blinking in chart view configuration 2021-09-16 18:18:28 +02:00
WelcomePage.ts (core) Implement DiscourseConnect to enable easy sign-in to community forum 2021-10-01 11:24:22 -04:00
welcomeTour.ts (core) Enable auto triggering of Welcome Tour, and various improvements. 2021-07-30 14:17:54 -04:00
widgetTypes.ts (core) move client code to core 2020-10-02 13:24:21 -04:00