mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
af4738b94a
Summary: Fixes a bug introduced in https://phab.getgrist.com/D3416 which exposed a new type of linking option that didn't actually work. Specifically it allowed selecting by a summary table when the target widget has a reference column to the source table of the summary. This diff correctly implements this linking by linking the reference column against the 'group' column of the summary table, so the source table data (which the client may not have access to) isn't involved. But the 'group' column name is hidden from the 'select by' option label to avoid confusion for users, so it just looks like another kind of summary table linking, and indeed it can be thought of purely in terms of matching groupby columns etc. Discussion here: https://grist.slack.com/archives/C02EGJ1FUCV/p1654039063055499 Also fixes a related old bug that offered similar meaningless options involving summary tables, like selecting the summary table by the source table or linking summary tables with disjoint groupby columns. Test Plan: Updated SelectBySummaryRef test and fixture doc for the new behaviour. Also updated a couple of older tests which were incorrectly asserting the buggy option to select a summary table by the source table. Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3464 |
||
|---|---|---|
| .. | ||
| aclui | ||
| components | ||
| lib | ||
| models | ||
| ui | ||
| ui2018 | ||
| widgets | ||
| accountMain.ts | ||
| app.css | ||
| app.js | ||
| browserCheck.ts | ||
| declarations.d.ts | ||
| errorMain.ts | ||
| exposeModulesForTests.js | ||
| logo.css | ||
| tsconfig.json | ||