gristlabs_grist-core/test
George Gevoian acc218398d (core) Fix hidden columns bug when editing data selection
Summary:
Editing data selection would sometimes cause columns to be hidden in the updated view. A
missing conditional was the culprit: generally, field visibility shouldn't be modified after the view is
updated, but we make an exception for charts to keep certain fields visible or hidden between
updates, so that chart configuration doesn't change too significantly and cause unexpected
data to be displayed. This special behavior for charts was erroneously being applied to non-charts
as well.

Also, when no columns were visible in a view, opening the row menu would cause an error to be
thrown. A loop was inadvertently using null control variables - an explicit check for non-null loop
variables was added, which skips the loop when no columns are visible.

Test Plan: Browser tests.

Reviewers: jarek

Reviewed By: jarek

Subscribers: jarek

Differential Revision: https://phab.getgrist.com/D3650
2022-10-18 08:36:11 -07:00
..
client (core) Fixing ACIndex highlightMatches functions 2022-08-26 08:34:16 +02:00
common give parseDate test more time (#278) 2022-09-09 17:05:29 -04:00
deployment Adding new lines at the end 2022-09-30 17:00:38 +02:00
fixtures (core) Fix hidden columns bug when editing data selection 2022-10-18 08:36:11 -07:00
gen-server (core) upgrade typeorm so we can support newer postgres 2022-09-02 15:34:21 -04:00
nbrowser (core) Fix hidden columns bug when editing data selection 2022-10-18 08:36:11 -07:00
server Return 403 error when origin is not trusted (#310) 2022-10-13 09:13:01 -04:00
chai-as-promised.js (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
init-mocha-webdriver.js Correct spelling mistakes 2022-02-19 09:46:49 +00:00
mocha.opts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
report-why-tests-hang.js (core) Move report-why-tests-hang helper to core 2021-04-26 23:52:16 -04:00
test_under_docker.sh Adding dedicated folder for external tests 2022-09-30 16:45:35 +02:00
testUtils.ts (core) add missing tsconfig file that affects IDEs 2022-05-27 13:48:58 -04:00
tsconfig.json (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
utils.js (core) Moving client and common tests to core 2022-08-23 19:20:10 +02:00
xunit-file.js (core) Parallelize jenkins by running on multiple machines. 2022-07-01 16:18:36 -04:00