gristlabs_grist-core/app/client
George Gevoian acc218398d (core) Fix hidden columns bug when editing data selection
Summary:
Editing data selection would sometimes cause columns to be hidden in the updated view. A
missing conditional was the culprit: generally, field visibility shouldn't be modified after the view is
updated, but we make an exception for charts to keep certain fields visible or hidden between
updates, so that chart configuration doesn't change too significantly and cause unexpected
data to be displayed. This special behavior for charts was erroneously being applied to non-charts
as well.

Also, when no columns were visible in a view, opening the row menu would cause an error to be
thrown. A loop was inadvertently using null control variables - an explicit check for non-null loop
variables was added, which skips the loop when no columns are visible.

Test Plan: Browser tests.

Reviewers: jarek

Reviewed By: jarek

Subscribers: jarek

Differential Revision: https://phab.getgrist.com/D3650
2022-10-18 08:36:11 -07:00
..
aclui (core) Fix CSS errors related to dark mode 2022-10-05 00:05:57 -07:00
components (core) Fix hidden columns bug when editing data selection 2022-10-18 08:36:11 -07:00
lib (core) Tweak autocomplete to only suggest team members 2022-10-18 08:08:05 -07:00
models (core) Tweak autocomplete to only suggest team members 2022-10-18 08:08:05 -07:00
ui (core) Tweak autocomplete to only suggest team members 2022-10-18 08:08:05 -07:00
ui2018 (core) Comments 2022-10-17 13:38:21 +02:00
widgets (core) Comments 2022-10-17 13:38:21 +02:00
accountMain.ts (core) Enable MFA configuration (and add SMS) 2022-01-19 13:55:54 -08:00
activationMain.ts (core) Add basic activation page to grist-ee 2022-08-23 10:30:52 -07:00
app.css (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
app.js (core) i18 2022-09-29 18:02:09 +02:00
billingMain.ts (core) Add basic activation page to grist-ee 2022-08-23 10:30:52 -07:00
browserCheck.ts (core) fix browser check and favicon in grist-core 2022-01-05 18:15:05 -05:00
declarations.d.ts (core) Comments 2022-10-17 13:38:21 +02:00
errorMain.ts (core) Enable MFA configuration (and add SMS) 2022-01-19 13:55:54 -08:00
exposeModulesForTests.js (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json (core) Migrate to SRP and add change password dialog 2022-03-16 21:35:06 -07:00