mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 23:20:47 +00:00
b8486dcdba
Summary: Changes auto-generated summary table IDs from e.g. `GristSummary_6_Table1` to `Table1_summary_A_B` (meaning `Table1` grouped by `A` and `B`). This makes it easier to write formulas involving summary tables, make API requests, understand logs, etc. Because these don't encode the source table ID as reliably as before, `decode_summary_table_name` now uses the summary table schema info, not just the summary table ID. Specifically, it looks at the type of the `group` column, which is `RefList:<source table id>`. Renaming a source table renames the summary table as before, and now renaming a groupby column renames the summary table as well. Conflicting table names are resolved in the usual way by adding a number at the end, e.g. `Table1_summary_A_B2`. These summary tables are not automatically renamed when the disambiguation is no longer needed. A new migration renames all summary tables to the new scheme, and updates formulas using summary tables with a simple regex. Test Plan: Updated many tests to use the new style of name. Added new Python tests to for resolving conflicts when renaming source tables and groupby columns. Added a test for the migration, including renames in formulas. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3508
56 lines
1.5 KiB
Python
56 lines
1.5 KiB
Python
"""
|
|
Some more test cases for summary tables, involving UNDO.
|
|
"""
|
|
import logger
|
|
import testutil
|
|
import test_engine
|
|
|
|
log = logger.Logger(__name__, logger.INFO)
|
|
|
|
class TestSummaryUndo(test_engine.EngineTestCase):
|
|
sample = testutil.parse_test_sample({
|
|
"SCHEMA": [
|
|
[1, "Person", [
|
|
[1, "state", "Text", False],
|
|
]]
|
|
],
|
|
"DATA": {
|
|
"Person": [
|
|
["id", "state", ],
|
|
[ 1, "NY", ],
|
|
[ 2, "IL", ],
|
|
[ 3, "ME", ],
|
|
[ 4, "NY", ],
|
|
[ 5, "IL", ],
|
|
]
|
|
}
|
|
})
|
|
|
|
def test_summary_undo1(self):
|
|
# This tests a particular case of a bug when a summary table wasn't fully updated after UNDO.
|
|
self.load_sample(self.sample)
|
|
# Create a summary section, grouped by the "State" column.
|
|
self.apply_user_action(["CreateViewSection", 1, 0, "record", [1], None])
|
|
self.assertTableData('Person_summary_state', cols="subset", data=[
|
|
[ "id", "state", "count"],
|
|
[ 1, "NY", 2],
|
|
[ 2, "IL", 2],
|
|
[ 3, "ME", 1],
|
|
])
|
|
|
|
out_actions = self.update_record('Person', 4, state='ME')
|
|
self.assertTableData('Person_summary_state', cols="subset", data=[
|
|
[ "id", "state", "count"],
|
|
[ 1, "NY", 1],
|
|
[ 2, "IL", 2],
|
|
[ 3, "ME", 2],
|
|
])
|
|
|
|
self.apply_undo_actions(out_actions.undo[0:1])
|
|
self.assertTableData('Person_summary_state', cols="subset", data=[
|
|
[ "id", "state", "count"],
|
|
[ 1, "NY", 2],
|
|
[ 2, "IL", 2],
|
|
[ 3, "ME", 1],
|
|
])
|