mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 15:20:48 +00:00
a0c53f2b61
Summary: Bug reported by user: https://gristlabs.getgrist.com/doc/check-ins/p/3#a1.s7.r1183.c19p Setting x axis to a column of type ChoiceList was breaking chart. This diff fixes that by splitting the record into several records: one for each choice. `test/nbrowser/ChartView1.ts` was becoming too big and long to run, so this diff introduces `test/nbrowser/ChartView2.ts` to add more test and `test/nbrowser/chartViewTestUtils.ts` to put all utilities or testing charts. Test Plan: Adds new test. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3041
63 lines
2.5 KiB
TypeScript
63 lines
2.5 KiB
TypeScript
import {typedCompare} from 'app/common/SortFunc';
|
|
import {decodeObject} from 'app/plugin/objtypes';
|
|
import {Datum} from 'plotly.js';
|
|
import range = require('lodash/range');
|
|
import uniqBy = require('lodash/uniqBy');
|
|
import flatten = require('lodash/flatten');
|
|
|
|
/**
|
|
* Sort all values in a list of series according to the values in the first one.
|
|
*/
|
|
export function sortByXValues(series: Array<{values: Datum[]}>): void {
|
|
// The order of points matters for graph types that connect points with lines: the lines are
|
|
// drawn in order in which the points appear in the data. For the chart types we support, it
|
|
// only makes sense to keep the points sorted. (The only downside is that Grist line charts can
|
|
// no longer produce arbitrary line drawings.)
|
|
if (!series[0]) { return; }
|
|
const xValues = series[0].values;
|
|
const indices = xValues.map((val, i) => i);
|
|
indices.sort((a, b) => typedCompare(xValues[a], xValues[b]));
|
|
for (const s of series) {
|
|
const values = s.values;
|
|
s.values = indices.map((i) => values[i]);
|
|
}
|
|
}
|
|
|
|
// creates new version of series that has a duplicate free version of the values in the first one.
|
|
export function uniqXValues<T extends {values: Datum[]}>(series: Array<T>): Array<T> {
|
|
if (!series[0]) { return []; }
|
|
const n = series[0].values.length;
|
|
const indexToKeep = new Set(uniqBy(range(n), (i) => series[0].values[i]));
|
|
return series.map((line: T) => ({
|
|
...line,
|
|
values: line.values.filter((_val, i) => indexToKeep.has(i))
|
|
}));
|
|
}
|
|
|
|
// Creates new version of series that split any entry whose value in the first series is a list into
|
|
// multiple entries, one entry for each list's item. For all other series, newly created entries have
|
|
// the same value as the original.
|
|
export function splitValues<T extends {values: Datum[]}>(series: Array<T>): Array<T> {
|
|
return splitValuesByIndex(series, 0);
|
|
}
|
|
|
|
// This method is like splitValues except it splits according to the values of the series at position index.
|
|
export function splitValuesByIndex<T extends {values: Datum[]}>(series: Array<T>, index: number): Array<T> {
|
|
const decoded = (series[index].values as any[]).map(decodeObject);
|
|
|
|
return series.map((s, si) => {
|
|
if (si === index) {
|
|
return {...series[index], values: flatten(decoded)};
|
|
}
|
|
let values: Datum[] = [];
|
|
for (const [i, splitByValue] of decoded.entries()) {
|
|
if (Array.isArray(splitByValue)) {
|
|
values = values.concat(Array(splitByValue.length).fill(s.values[i]));
|
|
} else {
|
|
values.push(s.values[i]);
|
|
}
|
|
}
|
|
return {...s, values};
|
|
});
|
|
}
|