gristlabs_grist-core/app/client/lib
Alex Hall c470c4041b (core) Use visibleCol instead of displayCol with createFormatter
Summary:
Some things (like rendering cells) use the `visibleCol` for `createFormatter`, while other things (like `CopySelection`) used the `displayCol`. For references, the display column has type Any and doesn't know about the original formatting. This resulted in formatting being lost when copying from reference columns even though formatting was preserved when copying from the original (visible) column which looked identical. This diff fixes this and ensures that `createFormatter` is always used with the `visibleCol`. This was agreed on in https://grist.slack.com/archives/C0234CPPXPA/p1639571321043000

Additionally:

- Replaces the functions `createVisibleColFormatter` computed properties `visibleColFormatter` as suggested by a `TODO`.
- Extracts common code from `createVisibleColFormatter` in `ColumnRec` and `ViewFieldRec`

Test Plan: Fixed a test in CopyPaste which displayed the previous inconsistent behaviour.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3189
2021-12-16 22:19:36 +02:00
..
ACIndex.ts (core) Fix autocomplete selection when options include emoji 2021-10-04 22:58:00 -04:00
ACSelect.ts (core) Replace time zone selector with one based on the newer autocomplete. 2021-07-23 08:02:05 -04:00
autocomplete.ts (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
browserGlobals.js (core) move client code to core 2020-10-02 13:24:21 -04:00
browserInfo.ts (core) Add our very own implementation of tokenfield (aka pillbox, tag list) 2021-05-03 17:16:24 -04:00
chartUtil.ts (core) Brings in the new donut charts. 2021-11-23 08:56:38 +01:00
copyToClipboard.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
CustomSectionElement.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
dblclick.ts (core) Fix double-tap on Android failing to select tapped cell; ensure gestures don't get interpreted as double-tap 2021-02-10 09:22:14 -05:00
Delay.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
dispose.d.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
dispose.js (core) move client code to core 2020-10-02 13:24:21 -04:00
DocPluginManager.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
dom.js (core) move client code to core 2020-10-02 13:24:21 -04:00
domAsync.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
download.js (core) move client code to core 2020-10-02 13:24:21 -04:00
FocusLayer.ts (core) Add support for editing on mobile. 2021-02-03 23:10:51 -05:00
fromKoSave.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
guessTimezone.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
helpScout.ts (core) Update HelpScout beacon to work with embedded documentation articles. 2021-12-09 22:22:55 -05:00
HomePluginManager.ts (core) Adding import from google drive to the home screen 2021-08-05 20:46:11 +02:00
imports.d.ts (core) tweak how search bar places cursor on sections 2021-08-30 09:26:28 -04:00
imports.js (core) tweak how search bar places cursor on sections 2021-08-30 09:26:28 -04:00
ImportSourceElement.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
koArray.d.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
koArray.js (core) move client code to core 2020-10-02 13:24:21 -04:00
koArrayWrap.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
koDom.js (core) Readonly editors 2021-06-17 19:12:16 +02:00
koDomScrolly.css (core) move client code to core 2020-10-02 13:24:21 -04:00
koDomScrolly.js (core) move client code to core 2020-10-02 13:24:21 -04:00
koForm.css (core) move client code to core 2020-10-02 13:24:21 -04:00
koForm.js (core) move client code to core 2020-10-02 13:24:21 -04:00
koSession.js (core) move client code to core 2020-10-02 13:24:21 -04:00
koUtil.js (core) move client code to core 2020-10-02 13:24:21 -04:00
loadScript.js (core) move client code to core 2020-10-02 13:24:21 -04:00
localStorageObs.ts (core) Make mobile the default mode. 2021-02-25 11:31:43 -05:00
log.ts (core) support ?embed=true and &style=light for a clean embed experience 2020-08-14 13:34:38 -04:00
Mousetrap.js (core) Improve focus and keyboard shortcuts in modals. 2020-10-03 22:56:00 -04:00
multiselect.css (core) move client code to core 2020-10-02 13:24:21 -04:00
multiselect.js (core) move client code to core 2020-10-02 13:24:21 -04:00
ObservableMap.js (core) move client code to core 2020-10-02 13:24:21 -04:00
ObservableSet.js (core) move client code to core 2020-10-02 13:24:21 -04:00
ReferenceUtils.ts (core) Use visibleCol instead of displayCol with createFormatter 2021-12-16 22:19:36 +02:00
SafeBrowser.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
SafeBrowserProcess.css (core) move client code to core 2020-10-02 13:24:21 -04:00
sessionObs.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
sortUtil.ts (core) Adding sort options for columns. 2021-11-03 15:31:39 +01:00
tableUtil.ts (core) Check document ID when parsing pasted references 2021-11-30 13:40:17 +02:00
testState.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
textUtils.ts (core) Check document ID when parsing pasted references 2021-11-30 13:40:17 +02:00
TokenField.ts (core) Disable mousedown on token delete button 2021-09-16 10:45:06 -07:00
uploads.ts (core) Extending Google Drive integration scope 2021-10-01 10:47:12 +02:00
UrlState.ts (core) Fixes persistence of the aclAsUser_ parameters across navigation 2021-05-19 09:51:38 +02:00