You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Dmitry S f024aaaf5d (core) Fix some bugs with ChoiceList in summary tables, and evaluation of lookups. ... Summary: Addresses several issues: - Error 'Cannot modify summary group-by column' when changing Text -> ChoiceList in the presence of summary tables. - Error 'ModifyColumn in unexpected position' when changing ChoiceList -> Text in the presence of summary tables. - Double-evaluation of trigger formulas in some cases. Fixes include: - Fixed verification that summary group-by columns match the underlying ones, and added comments to explain. - Avoid updating non-metadata lookups after each doc-action (early lookups generated extra actions to populate summary tables, causing the 'ModifyColumn in unexpected position' bug) - When updating formulas, do update lookups first. - Made a client-side tweak to avoid a JS error in case of some undos. Solution to reduce lookups is based on https://phab.getgrist.com/D3069?vs=on&id=12445, and tests for double-evaluation of trigger formulas are taken from there. Add a new test case to protect against bugs caused by incorrect order of evaluating #lookup columns. Enhanced ChoiceList browser test to check a conversion scenario in the presence of summary tables, previously triggering bugs. Test Plan: Various tests added or enhanced. Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: jarek Differential Revision: https://phab.getgrist.com/D3184		2 years ago
..
fixtures	(core) move more tests to grist-core	2 years ago
nbrowser	(core) Fix some bugs with ChoiceList in summary tables, and evaluation of lookups.	2 years ago
server	(core) add gvisor-based sandbox to jenkins test worker image	3 years ago
init-mocha-webdriver.js	(core) freshen grist-core build	3 years ago
mocha.opts	(core) Move report-why-tests-hang helper to core	3 years ago
report-why-tests-hang.js	(core) Move report-why-tests-hang helper to core	3 years ago
test_under_docker.sh	(core) run test:docker target prior to pushing grist-core image	2 years ago
tsconfig.json	(core) freshen grist-core build	3 years ago
xunit-file.js	(core) freshen grist-core build	3 years ago