mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
fc44a60edf
Summary: There has been inconsistency in using display email vs normalized email, which ends up creating some duplication in downstream analyses (e.g. the same user showing up twice with different capitalization). 1. Add UserProfile.loginEmail field with normalized email to prefer, when set, over the inconsistently used UserProfile.email. 2. In one place where it's not available, normalize the display email manually. 3. Clean up some code in Client.ts. Unrelated tweak to API Console to be clear when a URL parameter wasn't found (rather than show whatever happens to be the first value). Several test robustness improvements: - Misplaced parenthesis in gristWebDriverUtils has been causing optTimeout argument to be ignored in tests, and treated always as indefinite. - Attempt to fix SortMenu test by ignoring (retrying with logging) errors in waitForServer, which include "script timeout" errors that come from a non-configurable selenium or chromedriver timeout. - Attempt to improve onNewTab() helper, which plays a role in failing Billing tests. Test Plan: Tested manually the capitalization of logged emails. Counting on existing tests to catch issues. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D4188 |
||
|---|---|---|
| .. | ||
| entity | ||
| lib | ||
| migration | ||
| ApiServer.ts | ||
| sqlUtils.ts | ||