gristlabs_grist-core/test/nbrowser
Alex Hall 460f22b701 (core) Don't show hidden tables in table data options when adding widgets
Summary:
As reported in https://grist.slack.com/archives/C069RUP71/p1655316194602829, when a table is hidden by ACL, it was still showing as a blank 'ghost' option to select data when adding a widget:

{F55498}

The fix is simply to return `true` from `isHiddenTable` for empty table IDs, which indicate a table hidden by ACL. `TableRec.isHidden` is supposed to match this so I updated it too, and I cleaned up a tiny bit of other related code.

Test Plan: Extended `nbrowser/AccessRules1.ts` to test the data options when adding widgets.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3530
2022-07-21 16:28:28 +02:00
..
ActionLog.ts (core) Use different user in ActionLog tests 2022-05-05 14:04:03 -07:00
DuplicateDocument.ts (core) move more tests to grist-core 2021-12-10 18:33:07 -05:00
Fork.ts (core) Miscellaneous little logging improvements 2022-07-15 00:21:44 +02:00
gristUtils.ts (core) Don't show hidden tables in table data options when adding widgets 2022-07-21 16:28:28 +02:00
HomeIntro.ts (core) Update design of empty docs home page, and add a "Manage Team" button. 2022-06-03 12:58:57 -04:00
homeUtil.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
Smoke.ts (core) Remove code for unused welcome flows 2022-02-28 13:21:28 -08:00
testServer.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
testUtils.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00