mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 17:20:48 +00:00
8a26550312
Summary: Fix an error that used to happen on Chrome: `RangeError: Maximum call stack size exceeded`. Happened when clicking the `Other Values` checkbox when filtering a large table. Turns out culprit was a function call that was using a spread operator to pass a large number of argument to a function. Spread operator for passing multiple argument must not be used with too many arguments. Otherwise it could hit the engine's argument length limit. That limit varies across browser (webkit's javascriptcore engine has argument limit of 65536). Some interesting description of the limit can be found here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply#using_apply_and_built-in_functions In order to get the fix fast, implementing a proper test for it is left for a follow-up commit. Test Plan: - Manually tested on Chrome/FF Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D2779 |
||
|---|---|---|
| .. | ||
| entities | ||
| AppModel.ts | ||
| BaseRowModel.js | ||
| BillingModel.ts | ||
| ClientColumnGetters.ts | ||
| ColumnACIndexes.ts | ||
| ColumnFilter.ts | ||
| ColumnFilterMenuModel.ts | ||
| ConnectState.ts | ||
| DataRowModel.ts | ||
| DataTableModel.js | ||
| DataTableModelWithDiff.ts | ||
| DocData.ts | ||
| DocModel.ts | ||
| DocPageModel.ts | ||
| errors.ts | ||
| gristConfigCache.ts | ||
| gristUrlState.ts | ||
| HomeModel.ts | ||
| MetaRowModel.js | ||
| MetaTableModel.js | ||
| modelUtil.js | ||
| NotifyModel.ts | ||
| QuerySet.ts | ||
| rowset.ts | ||
| rowuid.js | ||
| SearchModel.ts | ||
| SectionFilter.ts | ||
| TableData.ts | ||
| TableModel.js | ||
| TreeModel.ts | ||
| UserManagerModel.ts | ||
| UserPrefs.ts | ||
| WorkspaceInfo.ts | ||