mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 19:10:44 +00:00
51ff72c15e
Summary: Building: - Builds no longer wait for tsc for either client, server, or test targets. All use esbuild which is very fast. - Build still runs tsc, but only to report errors. This may be turned off with `SKIP_TSC=1` env var. - Grist-core continues to build using tsc. - Esbuild requires ES6 module semantics. Typescript's esModuleInterop is turned on, so that tsc accepts and enforces correct usage. - Client-side code is watched and bundled by webpack as before (using esbuild-loader) Code changes: - Imports must now follow ES6 semantics: `import * as X from ...` produces a module object; to import functions or class instances, use `import X from ...`. - Everything is now built with isolatedModules flag. Some exports were updated for it. Packages: - Upgraded browserify dependency, and related packages (used for the distribution-building step). - Building the distribution now uses esbuild's minification. babel-minify is no longer used. Test Plan: Should have no behavior changes, existing tests should pass, and docker image should build too. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3506
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
import DataTableModel from 'app/client/models/DataTableModel';
|
|
import { ColumnGetter, ColumnGetters } from 'app/common/ColumnGetters';
|
|
import * as gristTypes from 'app/common/gristTypes';
|
|
import { choiceGetter } from 'app/common/SortFunc';
|
|
import { Sort } from 'app/common/SortSpec';
|
|
|
|
/**
|
|
*
|
|
* An implementation of ColumnGetters for the client, drawing
|
|
* on the observables and models available in that context.
|
|
*
|
|
*/
|
|
export class ClientColumnGetters implements ColumnGetters {
|
|
|
|
// If the "unversioned" option is set, then cells with multiple
|
|
// versions will be read as a single version - the first version
|
|
// available of parent, local, or remote. This can make sense for
|
|
// sorting, so cells appear in a reasonably sensible place.
|
|
constructor(private _tableModel: DataTableModel, private _options: {
|
|
unversioned?: boolean} = {}) {
|
|
}
|
|
|
|
public getColGetter(colSpec: Sort.ColSpec): ColumnGetter | null {
|
|
const rowModel = this._tableModel.docModel.columns.getRowModel(Sort.getColRef(colSpec));
|
|
const colId = rowModel.colId();
|
|
let getter: ColumnGetter|undefined = this._tableModel.tableData.getRowPropFunc(colId);
|
|
if (!getter) { return null; }
|
|
if (this._options.unversioned && this._tableModel.tableData.mayHaveVersions()) {
|
|
const valueGetter = getter;
|
|
getter = (rowId) => {
|
|
const value = valueGetter(rowId);
|
|
if (value && gristTypes.isVersions(value)) {
|
|
const versions = value[1];
|
|
return ('parent' in versions) ? versions.parent :
|
|
('local' in versions) ? versions.local : versions.remote;
|
|
}
|
|
return value;
|
|
};
|
|
}
|
|
const details = Sort.specToDetails(colSpec);
|
|
if (details.orderByChoice) {
|
|
if (rowModel.pureType() === 'Choice') {
|
|
const choices: string[] = rowModel.widgetOptionsJson.peek()?.choices || [];
|
|
getter = choiceGetter(getter, choices);
|
|
}
|
|
}
|
|
return getter;
|
|
}
|
|
|
|
public getManualSortGetter(): ((rowId: number) => any) | null {
|
|
const manualSortCol = this._tableModel.tableMetaRow.columns().peek().find(
|
|
(c: any) => c.colId() === gristTypes.MANUALSORT);
|
|
if (!manualSortCol) {
|
|
return null;
|
|
}
|
|
return this.getColGetter(manualSortCol.getRowId());
|
|
}
|
|
}
|