gristlabs_grist-core/app/client
Dmitry S 14cdd47675 (core) When checking for metadata consistency, check for stray column records too
Summary:
Currently, an undo of a non-last action can leave the doc in an inconsistent
state. For example, it may remove a table, but fail to remove all columns of
it from metadata. We normally check that schema corresponds to metadata, but
stray columns were not visible to this check, and instead caused later table
additions to fail.

This diff fixes the check to fail the action that causes stray columns, and
to restore the doc to a consistent state.

Note that this only handles schema-metadata inconsistencies, but an undo of a
non-last action can easily create other surprises.

Test Plan: Added a test case that triggered inconsistency before, and now triggers a failed undo.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2715
2021-01-27 18:10:11 -05:00
..
aclui (core) Add a Users dropdown to AccessRules page. 2021-01-22 09:20:40 -05:00
components (core) When checking for metadata consistency, check for stray column records too 2021-01-27 18:10:11 -05:00
lib (core) Add viewport meta tag conditionally, and show a toggle for it on small devices. 2021-01-21 14:54:02 -05:00
models (core) Show a clearer message when actions are blocked by ACL rules 2021-01-22 10:21:36 -05:00
ui (core) Fix page panels scrolling out of the viewport. 2021-01-27 18:25:41 +01:00
ui2018 (core) Add viewport meta tag conditionally, and show a toggle for it on small devices. 2021-01-21 14:54:02 -05:00
widgets (core) Convert a few widgets to typescript and grainjs. 2020-11-23 09:49:55 -05:00
app.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
app.js (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
declarations.d.ts (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
exposeModulesForTests.js (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json freshen app/client/ui2018/cssVars.ts 2020-06-23 16:16:38 -04:00