mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 13:20:47 +00:00
d1c1416d78
Summary: We used tslint earlier, and on switching to eslint, some rules were not transfered. This moves more rules over, for consistent conventions or helpful warnings. - Name private members with a leading underscore. - Prefer interface over a type alias. - Use consistent spacing around ':' in type annotations. - Use consistent spacing around braces of code blocks. - Use semicolons consistently at the ends of statements. - Use braces around even one-liner blocks, like conditionals and loops. - Warn about shadowed variables. Test Plan: Fixed all new warnings. Should be no behavior changes in code. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2831
58 lines
2.0 KiB
JavaScript
58 lines
2.0 KiB
JavaScript
var _ = require('underscore');
|
|
var ko = require('knockout');
|
|
var BackboneEvents = require('backbone').Events;
|
|
|
|
var dispose = require('../lib/dispose');
|
|
var dom = require('../lib/dom');
|
|
var kd = require('../lib/koDom');
|
|
|
|
// Rather than require the whole of highlight.js, require just the core with the one language we
|
|
// need, to keep our bundle smaller and the build faster.
|
|
var hljs = require('highlight.js/lib/highlight');
|
|
hljs.registerLanguage('python', require('highlight.js/lib/languages/python'));
|
|
|
|
function CodeEditorPanel(gristDoc) {
|
|
this._gristDoc = gristDoc;
|
|
this._schema = ko.observable('');
|
|
|
|
this.listenTo(this._gristDoc, 'schemaUpdateAction', this.onSchemaAction);
|
|
this.onSchemaAction(); // Fetch the schema to initialize
|
|
}
|
|
dispose.makeDisposable(CodeEditorPanel);
|
|
_.extend(CodeEditorPanel.prototype, BackboneEvents);
|
|
|
|
CodeEditorPanel.prototype.buildDom = function() {
|
|
// The tabIndex enables the element to gain focus, and the .clipboard class prevents the
|
|
// Clipboard module from re-grabbing it. This is a quick fix for the issue where clipboard
|
|
// interferes with text selection. TODO it should be possible for the Clipboard to never
|
|
// interfere with text selection even for un-focusable elements.
|
|
return dom('div.g-code-panel.clipboard',
|
|
{tabIndex: "-1"},
|
|
kd.scope(this._schema, function(schema) {
|
|
// The reason to scope and rebuild instead of using `kd.text(schema)` is because
|
|
// hljs.highlightBlock(elem) replaces `elem` with a whole new dom tree.
|
|
if (!schema) { return null; }
|
|
return dom(
|
|
'code.g-code-viewer.python',
|
|
schema,
|
|
dom.hide,
|
|
dom.defer(function(elem) {
|
|
hljs.highlightBlock(elem);
|
|
dom.show(elem);
|
|
})
|
|
);
|
|
})
|
|
);
|
|
};
|
|
|
|
CodeEditorPanel.prototype.onSchemaAction = function(actions) {
|
|
return this._gristDoc.docComm.fetchTableSchema()
|
|
.then(schema => {
|
|
if (!this.isDisposed()) {
|
|
this._schema(schema);
|
|
}
|
|
});
|
|
};
|
|
|
|
module.exports = CodeEditorPanel;
|