mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-01 10:50:48 +00:00
f59c1edf16
Summary: We have an important batch of old browser tests that depend on a pseudo-promise manager selenium's node client used to have. That manager was dropped in v4 (see changelog https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/CHANGES.md). I tried porting some wholesale to our newer style of writing tests, and it is a bit of a bear (and would also be hard work to review). So instead I tried something else: remapping the `webdriverjq` implementation to work with mocha-webdriver. This works pretty well. Some API differences are hard to reconcile, but so far most test code just needs async/await changes to port, meaning a lot less thinking, and probably easier to review overall. The important property of the ports tests is that they no longer import or require `selenium-webdriver`. mocha-webdriver depends on selenium-webdriver, but a newer version. I haven't tried dealing with types, since that doesn't matter much - these tests aren't under active development, they are just important for preventing regressions. Follow up work would be porting the remainder of the tests which, while a slog, I'm hoping is no longer a quagmire. Once the tests are ported, I'd propose moving them to `core`. Test Plan: Test porting Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3825 |
||
|---|---|---|
| .. | ||
| aclTestUtils.ts | ||
| ActionLog.ts | ||
| AttachmentsLinking.ts | ||
| ChoiceList.ts | ||
| customUtil.ts | ||
| CustomView.ts | ||
| CustomWidgets.ts | ||
| CustomWidgetsConfig.ts | ||
| DescriptionColumn.ts | ||
| DocTutorial.ts | ||
| DuplicateDocument.ts | ||
| Fork.ts | ||
| gristUtils.ts | ||
| HomeIntro.ts | ||
| homeUtil.ts | ||
| LanguageSettings.ts | ||
| Localization.ts | ||
| MultiColumn.ts | ||
| Pages.ts | ||
| ReferenceColumns.ts | ||
| ReferenceList.ts | ||
| RefTransforms.ts | ||
| RightPanel.ts | ||
| RightPanelSelectBy.ts | ||
| RowMenu.ts | ||
| saveViewSection.ts | ||
| SelectBy.ts | ||
| SelectByRefList.ts | ||
| SelectByRightPanel.ts | ||
| SelectBySummary.ts | ||
| SelectBySummaryRef.ts | ||
| SelectionSummary.ts | ||
| Smoke.ts | ||
| testServer.ts | ||
| testUtils.ts | ||
| ToggleColumns.ts | ||