Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
6722512d96
gristlabs_grist-core/test/nbrowser
History
Alex Hall 225a76c9cb (core) Don't throw error in onRecord(s) for insufficient access for includeColumns 
Summary:
This removes checking for full access in `onRecord/onRecords` when `includeColumns` is a non-default value. The check had two problems:

1. It relied on the access level being present in the URL query parameters, which doesn't work if the page has redirected. See the discussion in https://grist.slack.com/archives/C0234CPPXPA/p1702576602615509. There seems to be no way to reliably and synchronously check the access level.
2. Calling `onRecords` before `ready` and forgetting to handle an error from the access check meant that `ready` wouldn't be called, so Grist couldn't request the correct access level from the user. I made this mistake and it seems like a nasty footgun.

Ultimately this has no effect on security, as an error will still be raised, but in a place where the widget developer can't catch it. They'll still see an error message in the console, and they can still check the access level reliably using `onOptions`, so I think this is OK.

Test Plan: Updated nbrowser test

Reviewers: georgegevoian, paulfitz

Reviewed By: georgegevoian, paulfitz

Differential Revision: https://phab.getgrist.com/D4145
2023-12-30 10:16:40 +02:00
..
aclTestUtils.ts (core) Preserving cursor position when linked state is removed. 2023-02-08 21:54:55 +01:00
ActionLog.ts Fix failing Docker tests (#724) 2023-11-06 12:49:32 -05:00
AttachedCustomWidget.ts (core) support for bundling custom widgets with the Grist app 2023-10-27 17:00:10 -04:00
AttachmentsLinking.ts (core) Fix linking of new records when attachment is the first thing added. 2023-03-09 08:54:36 -05:00
BundleActions.ts (core) Polish "Click to insert $id" tooltip 2023-08-09 07:38:34 -07:00
CellColor.ts (core) Enable the 'none' option in ColorSelect for cell and header text styles 2023-12-04 19:13:52 -05:00
ChartView1.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00
chartViewTestUtils.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00
ChoiceList.ts (core) Add shortcut for opening Record Card 2023-12-08 11:32:45 -05:00
ClientUnitTests.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
CodeEditor.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ColumnOps.ntest.js (core) Capitalization in new colum menu 2023-12-05 17:01:22 +01:00
CopyPaste2.ntest.js (core) Update dependencies 2023-10-11 17:36:58 -04:00
CopyPaste.ts Fix CI failures (#696) 2023-10-17 15:38:19 -04:00
CopyPasteColumnOptions.ts Fix CI failures (#696) 2023-10-17 15:38:19 -04:00
CopyPasteLinked.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00
customUtil.ts (core) Moving widget tests to core 2022-09-06 17:17:14 +02:00
CustomView.ts (core) Don't throw error in onRecord(s) for insufficient access for includeColumns 2023-12-30 10:16:40 +02:00
CustomWidgets.ts allow bundled widgets to be hidden from dropdown, and nested (#714) 2023-10-30 21:13:21 -04:00
CustomWidgetsConfig.ts (core) support for bundling custom widgets with the Grist app 2023-10-27 17:00:10 -04:00
Dates.ntest.js tweak a date test that can occasionally fail (#592) 2023-07-26 08:08:55 -04:00
DeleteColumnsUndo.ts (core) Fix error in sandbox when removing multiple summary source columns 2023-09-27 16:23:49 +02:00
DescriptionColumn.ts (core) Removing the new menu flag 2023-11-08 07:37:54 +01:00
DescriptionWidget.ts (core) Adding links to description tooltips 2023-08-04 18:34:04 +02:00
DetailView.ntest.js (core) Summary: 2023-10-20 15:43:32 +02:00
DetailView.ts (core) Clicking on a link in a cell won't open the editor. 2023-09-14 17:28:50 +02:00
DocTutorial.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00
DuplicateDocument.ts (core) Showing workspace selector on duplicate document popup 2023-09-07 16:16:33 +02:00
Export.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Features.ts (core) Tweak navbar, breadcrumbs, and sign-in buttons 2023-07-26 22:26:55 -07:00
FieldConfigTab.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
FieldSettings2.ts (core) Fix the switch of a new column from Common to Separate settings 2023-10-11 09:23:21 -04:00
FieldSettings.ntest.js (core) Update dependencies 2023-10-11 17:36:58 -04:00
FillLinkedRecords.ntest.js Fixing widget selection (#777) 2023-11-27 13:45:38 +01:00
FilterLinkChain.ts (core) Fix selecting new row in chain of filter links 2023-12-05 16:56:13 +02:00
Fork.ts (core) Revert part of the recent tweaks to AppHeader 2023-09-20 11:27:46 -04:00
FormView.ts (core) Forms feature 2023-12-20 13:23:12 +01:00
GridOptions.ntest.js (core) TypeTransform race condition fix 2023-08-02 17:11:34 +02:00
GridViewBugs.ts (core) Fixing bug with hiding multiple columns 2023-12-08 10:20:43 +01:00
GridViewNewColumnMenu.ts (core) Capitalization in new colum menu 2023-12-05 17:01:22 +01:00
gristUtil-nbrowser.js (core) Update dependencies 2023-10-11 17:36:58 -04:00
gristUtils.ts (core) Forms feature 2023-12-20 13:23:12 +01:00
gristWebDriverUtils.ts (core) Forms feature 2023-12-20 13:23:12 +01:00
HeaderColor.ts Header colored (#581) 2023-08-07 11:01:35 -07:00
Health.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
HomeIntro.ts (core) Add support for auto-copying docs on signup 2023-09-06 15:12:08 -04:00
HomeIntroWithoutPlaygound.ts Introduce GRIST_ANON_PLAYGROUND variable #642 (#651) 2023-09-08 09:05:52 -04:00
homeUtil.ts (core) Add support for auto-copying docs on signup 2023-09-06 15:12:08 -04:00
importerTestUtils.ts (core) Add support for auto-copying docs on signup 2023-09-06 15:12:08 -04:00
ImportReferences.ts (core) Add support for auto-copying docs on signup 2023-09-06 15:12:08 -04:00
LanguageSettings.ts (core) Fix missing placeholder flag icon 2023-02-26 22:23:04 -05:00
LinkingBidirectional.ts (core) Tests and bug fixes for bidirectional linking 2023-10-10 15:31:48 +02:00
LinkingErrors.ts (core) Fix for linking issue. 2023-12-20 12:57:41 +01:00
LinkingSelector.ts (core) Tests and bug fixes for bidirectional linking 2023-10-10 15:31:48 +02:00
Localization.ts skip building test harness in docker image (#551) 2023-06-30 05:50:40 -04:00
MultiColumn.ts (core) Removing the new menu flag 2023-11-08 07:37:54 +01:00
NewDocument.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Pages.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00
Properties.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
RawData.ts (core) Add shortcut for opening Record Card 2023-12-08 11:32:45 -05:00
RecordCards.ts (core) Add shortcut for opening Record Card 2023-12-08 11:32:45 -05:00
ReferenceColumns.ts (core) Record Cards 2023-11-19 20:12:37 -05:00
ReferenceList.ts (core) Enable Record Cards 2023-11-21 16:49:41 -05:00
RefNumericChange.ts (core) Fix undo of Ref->Numeric conversion. 2023-09-27 08:53:53 -04:00
RefTransforms.ts (core) Fix bug preventing changes to ref list table 2022-10-17 07:49:54 -07:00
RemoveTransformColumns.ts (core) Remove transform columns on shutdown 2023-11-14 22:31:34 +02:00
RightPanel.ts Linkstate refactor (#609) 2023-09-08 14:21:32 -04:00
RightPanelSelectBy.ts Bidirectional Linking (#622) 2023-09-25 18:48:18 -04:00
RowMenu.ts (core) Fix hidden columns bug when editing data selection 2022-10-18 08:36:11 -07:00
SavePosition.ntest.js Fixing widget selection (#777) 2023-11-27 13:45:38 +01:00
saveViewSection.ts (core) Adds a UI panel for managing webhooks 2023-05-08 18:25:27 -04:00
SelectBy.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
SelectByRefList.ts (core) Allow adding rows to widgets filtered by a link using a formula column 2023-12-18 20:28:41 +02:00
SelectByRightPanel.ts (core) Preserving cursor position when linked state is removed. 2023-02-08 21:54:55 +01:00
SelectBySummary.ts (core) Allow adding rows to widgets filtered by a link using a formula column 2023-12-18 20:28:41 +02:00
SelectBySummaryRef.ts avoid test files importing other test files (#550) 2023-06-29 03:15:14 -04:00
SelectionSummary.ts fix: don't count falses in summary (#589) 2023-07-26 12:08:04 -07:00
ShiftSelection.ts Support grid selection with Ctrl+Shift+Arrow (#615) 2023-08-14 09:28:41 -07:00
Smoke.ts (core) Add support for auto-copying docs on signup 2023-09-06 15:12:08 -04:00
SortDates.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
SortEditSave.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Summaries.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
SupportGrist.ts (core) Add Support Grist page and nudge 2023-07-04 17:36:59 -04:00
testServer.ts (core) Exit more cleanly on unhandled errors, and handle errors writing to Clients. 2023-12-01 09:42:00 -05:00
testUtils.ts (core) Highlight rows used as a selector in linking, but do not show 'inactive' cursors. 2023-06-21 12:21:19 -04:00
TextEditor.ntest.js (core) Removing the new menu flag 2023-11-08 07:37:54 +01:00
ToggleColumns.ts (core) When a checkbox is clicked on a new record, set default values determined by linking 2022-11-10 14:34:40 -05:00
TokenField.ts (core) Fixing DELETE and BACKSPACE keys on ChoiceList and RefList editor. 2023-06-01 16:53:38 +02:00
TypeChange.ntest.js Fixing widget selection (#777) 2023-11-27 13:45:38 +01:00
UndoJumps.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
UploadLimits.ts Fix CI failures (#696) 2023-10-17 15:38:19 -04:00
Validations.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ViewConfigTab.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ViewLayoutCollapse.ts (core) Fixing bug with collapsed custom widget. 2023-11-08 07:36:21 +01:00
ViewLayoutUtils.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00
Views.ntest.js Fixing widget selection (#777) 2023-11-27 13:45:38 +01:00
webdriverjq-nbrowser.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
webdriverjq.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
WebhookOverflow.ts (core) When a webhook is disabled, clear its queue 2023-11-07 15:48:35 +02:00
WebhookPage.ts (core) Update dependencies 2023-10-11 17:36:58 -04:00