mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 09:20:49 +00:00
c470c4041b
Summary: Some things (like rendering cells) use the `visibleCol` for `createFormatter`, while other things (like `CopySelection`) used the `displayCol`. For references, the display column has type Any and doesn't know about the original formatting. This resulted in formatting being lost when copying from reference columns even though formatting was preserved when copying from the original (visible) column which looked identical. This diff fixes this and ensures that `createFormatter` is always used with the `visibleCol`. This was agreed on in https://grist.slack.com/archives/C0234CPPXPA/p1639571321043000 Additionally: - Replaces the functions `createVisibleColFormatter` computed properties `visibleColFormatter` as suggested by a `TODO`. - Extracts common code from `createVisibleColFormatter` in `ColumnRec` and `ViewFieldRec` Test Plan: Fixed a test in CopyPaste which displayed the previous inconsistent behaviour. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3189
63 lines
1.9 KiB
JavaScript
63 lines
1.9 KiB
JavaScript
var dispose = require('../lib/dispose');
|
|
const {Computed, fromKo} = require('grainjs');
|
|
|
|
const {cssLabel, cssRow} = require('app/client/ui/RightPanel');
|
|
const {colorSelect} = require('app/client/ui2018/ColorSelect');
|
|
|
|
/**
|
|
* AbstractWidget - The base of the inheritance tree for widgets.
|
|
* @param {Function} field - The RowModel for this view field.
|
|
* @param {string|undefined} options.defaultTextColor - A hex value to set the default text color
|
|
* for the widget. Omit defaults to '#000000'.
|
|
*/
|
|
function AbstractWidget(field, opts = {}) {
|
|
this.field = field;
|
|
this.options = field.widgetOptionsJson;
|
|
const {defaultTextColor = '#000000'} = opts;
|
|
|
|
this.valueFormatter = this.field.visibleColFormatter;
|
|
|
|
this.textColor = Computed.create(this, (use) => use(this.field.textColor) || defaultTextColor)
|
|
.onWrite((val) => this.field.textColor(val === defaultTextColor ? undefined : val));
|
|
}
|
|
dispose.makeDisposable(AbstractWidget);
|
|
|
|
/**
|
|
* Builds the DOM showing configuration buttons and fields in the sidebar.
|
|
*/
|
|
AbstractWidget.prototype.buildConfigDom = function() {
|
|
throw new Error("Not Implemented");
|
|
};
|
|
|
|
/**
|
|
* Builds the transform prompt config DOM in the few cases where it is necessary.
|
|
* Child classes need not override this function if they do not require transform config options.
|
|
*/
|
|
AbstractWidget.prototype.buildTransformConfigDom = function() {
|
|
return null;
|
|
};
|
|
|
|
/**
|
|
* Builds the data cell DOM.
|
|
* @param {DataRowModel} row - The rowModel object.
|
|
*/
|
|
AbstractWidget.prototype.buildDom = function(row) {
|
|
throw new Error("Not Implemented");
|
|
};
|
|
|
|
AbstractWidget.prototype.buildColorConfigDom = function() {
|
|
return [
|
|
cssLabel('CELL COLOR'),
|
|
cssRow(
|
|
colorSelect(
|
|
this.textColor,
|
|
fromKo(this.field.fillColor),
|
|
// Calling `field.widgetOptionsJson.save()` saves both fill and text color settings.
|
|
() => this.field.widgetOptionsJson.save()
|
|
)
|
|
)
|
|
];
|
|
};
|
|
|
|
module.exports = AbstractWidget;
|