mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 18:40:45 +00:00
65013331a3
Summary: - When importing into a Ref column, use lookupOne() formula for correct previews. - When selecting columns to import into a Ref column, now a Numeric column like 'Order' will produce two options: "Order" and "Order (as row ID)". - Fixes exports to correct the formatting of visible columns. This addresses multiple bugs: 1. Formatting wasn't used, e.g. a Ref showing a custom-formatted date was still presented as YYYY-MM-DD in CSVs. 2. Ref showing a Numeric column was formatted as if a row ID (e.g. `Table1[1.5]`), which is very wrong. - If importing into a table that doesn't have a primary view, don't switch page after import. Refactorings: - Generalize GenImporterView to be usable in more cases; removed near-duplicated logic from node side - Some other refactoring in importing code. - Fix field/column option selection in ValueParser - Add NUM() helper to turn integer-valued floats into ints, useful for "as row ID" lookups. Test Plan: Added test cases for imports into reference columns, updated Exports test fixtures. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3875 |
||
|---|---|---|
| .. | ||
| video | ||
| BooleanData.xlsx | ||
| CCTransactions.csv | ||
| ChartData-Sort_Test.csv | ||
| ChartData.csv | ||
| cities_broken.jgrist | ||
| Cities.csv | ||
| cities.jgrist | ||
| CodeEditor.test.csv | ||
| ColumnFilterData_A.csv | ||
| ColumnFilterData_B.csv | ||
| dirtyNames.json | ||
| empty_data.jgrist | ||
| empty_excel.xlsx | ||
| EmptyDate.csv | ||
| file1.mov | ||
| file2.mp3 | ||
| file3.zip | ||
| FileUploadData.csv | ||
| formatted_numbers.csv | ||
| gplaypattern.png | ||
| grist.png | ||
| homicide_rates.xlsx | ||
| htmlfile.html | ||
| ImportReferences-Tasks.csv | ||
| mixed_dates.csv | ||
| name_references.csv | ||
| names.json | ||
| sample.pdf | ||
| SchoolData.csv | ||
| simple_array.json | ||
| spotifyGetSeveralAlbums.json | ||
| StudentData.csv | ||
| unicode_headers.csv | ||
| unicode_headers.xlsx | ||
| UploadedData1.csv | ||
| UploadedData1Extended.csv | ||
| UploadedData2.csv | ||
| UploadedData2Extended.csv | ||
| UploadedData3.csv | ||
| UploadedDataEmpty.csv | ||
| World-v0.xlsx | ||
| World-v1.xlsx | ||
