mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-01 11:10:49 +00:00
519f1be93a
Summary: Following up on a small bug introduced in https://phab.getgrist.com/D3464. When a table has a column referencing the same table, then there can be two 'select by' options with the same label which is just the name of a summary table on the same page. The first option is simply filtering based on the summary table. The second option is linking the ref column in the source against the group column in the summary, but the name of the group column is hidden which leads to the ambiguity. The solution in this diff is to always show the target node (source table) column name if the source node (summary table) column was the hidden group column. This also changes the label in the case where the reference to the source table isn't in the source table - see the updated test. This isn't strictly necessary in this case so I'm not 100% about the desired behaviour, but I don't think it hurts. Test Plan: Tested disambiguation manually. Updated existing test. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3472 |
||
|---|---|---|
| .. | ||
| aclui | ||
| components | ||
| lib | ||
| models | ||
| ui | ||
| ui2018 | ||
| widgets | ||
| accountMain.ts | ||
| app.css | ||
| app.js | ||
| browserCheck.ts | ||
| declarations.d.ts | ||
| errorMain.ts | ||
| exposeModulesForTests.js | ||
| logo.css | ||
| tsconfig.json | ||