mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
8684c9e930
Summary: Traceback is available on the Creator Panel in the formula editor. It is evaluated the same way as for normal formulas. In case when the traceback is not available, only the error name is displayed with information that traceback is not available. Cell with an error, when edited, shows the previous valid value that was used before the error happened (or None for new rows). Value is stored inside the RaisedException object that is stored in a cell. Test Plan: Created tests Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: alexmojaki, dsagal Differential Revision: https://phab.getgrist.com/D3033
279 lines
10 KiB
TypeScript
279 lines
10 KiB
TypeScript
import type {GristDoc} from 'app/client/components/GristDoc';
|
|
import type {ColumnRec} from 'app/client/models/entities/ColumnRec';
|
|
import type {CursorPos} from "app/client/components/Cursor";
|
|
import {buildHighlightedCode, cssCodeBlock} from 'app/client/ui/CodeHighlight';
|
|
import {buildFormulaTriggers} from 'app/client/ui/TriggerFormulas';
|
|
import {cssLabel, cssRow} from 'app/client/ui/RightPanel';
|
|
import {colors, testId, vars} from 'app/client/ui2018/cssVars';
|
|
import {textInput} from 'app/client/ui2018/editableLabel';
|
|
import {cssIconButton, icon} from 'app/client/ui2018/icons';
|
|
import {menu, menuItem} from 'app/client/ui2018/menus';
|
|
import {sanitizeIdent} from 'app/common/gutil';
|
|
import {Computed, dom, fromKo, MultiHolder, Observable, styled, subscribe} from 'grainjs';
|
|
import * as ko from 'knockout';
|
|
import debounce = require('lodash/debounce');
|
|
|
|
export function buildNameConfig(owner: MultiHolder, origColumn: ColumnRec, cursor: ko.Computed<CursorPos>) {
|
|
const untieColId = origColumn.untieColIdFromLabel;
|
|
|
|
const editedLabel = Observable.create(owner, '');
|
|
const editableColId = Computed.create(owner, editedLabel, (use, edited) =>
|
|
'$' + (edited ? sanitizeIdent(edited) : use(origColumn.colId)));
|
|
const saveColId = (val: string) => origColumn.colId.saveOnly(val.startsWith('$') ? val.slice(1) : val);
|
|
|
|
// We will listen to cursor position and force a blur event on
|
|
// the text input, which will trigger save before the column observable
|
|
// will change its value.
|
|
// Otherwise, blur will be invoked after column change and save handler will
|
|
// update a different column.
|
|
let editor: HTMLInputElement | undefined;
|
|
owner.autoDispose(
|
|
cursor.subscribe(() => {
|
|
editor?.blur();
|
|
})
|
|
);
|
|
|
|
return [
|
|
cssLabel('COLUMN LABEL AND ID'),
|
|
cssRow(
|
|
cssColLabelBlock(
|
|
editor = textInput(fromKo(origColumn.label),
|
|
async val => { await origColumn.label.saveOnly(val); editedLabel.set(''); },
|
|
dom.on('input', (ev, elem) => { if (!untieColId.peek()) { editedLabel.set(elem.value); } }),
|
|
dom.boolAttr('disabled', origColumn.disableModify),
|
|
testId('field-label'),
|
|
),
|
|
textInput(editableColId,
|
|
saveColId,
|
|
dom.boolAttr('disabled', use => use(origColumn.disableModify) || !use(origColumn.untieColIdFromLabel)),
|
|
cssCodeBlock.cls(''),
|
|
{style: 'margin-top: 8px'},
|
|
testId('field-col-id'),
|
|
),
|
|
),
|
|
cssColTieBlock(
|
|
cssColTieConnectors(),
|
|
cssToggleButton(icon('FieldReference'),
|
|
cssToggleButton.cls('-selected', (use) => !use(untieColId)),
|
|
dom.on('click', () => untieColId.saveOnly(!untieColId.peek())),
|
|
testId('field-derive-id')
|
|
),
|
|
)
|
|
),
|
|
];
|
|
}
|
|
|
|
type BuildEditor = (cellElem: Element) => void;
|
|
|
|
export function buildFormulaConfig(
|
|
owner: MultiHolder, origColumn: ColumnRec, gristDoc: GristDoc, buildEditor: BuildEditor
|
|
) {
|
|
const clearColumn = () => gristDoc.clearColumns([origColumn.id.peek()]);
|
|
const convertIsFormula =
|
|
(opts: {toFormula: boolean, noRecalc?: boolean}) => gristDoc.convertIsFormula([origColumn.id.peek()], opts);
|
|
const errorMessage = createFormulaErrorObs(owner, gristDoc, origColumn);
|
|
|
|
return dom.maybe(use => {
|
|
if (!use(origColumn.id)) { return null; } // Invalid column, show nothing.
|
|
if (use(origColumn.isEmpty)) { return "empty"; }
|
|
return use(origColumn.isFormula) ? "formula" : "data";
|
|
},
|
|
(type: "empty"|"formula"|"data") => {
|
|
function buildHeader(label: string, menuFunc: () => Element[]) {
|
|
return cssRow(
|
|
cssInlineLabel(label,
|
|
testId('field-is-formula-label'),
|
|
),
|
|
cssDropdownLabel('Actions', icon('Dropdown'), menu(menuFunc),
|
|
cssDropdownLabel.cls('-disabled', origColumn.disableModify),
|
|
testId('field-actions-menu'),
|
|
)
|
|
);
|
|
}
|
|
function buildFormulaRow(placeholder = 'Enter formula') {
|
|
return [
|
|
cssRow(dom.create(buildFormula, origColumn, buildEditor, placeholder)),
|
|
dom.maybe(errorMessage, errMsg => cssRow(cssError(errMsg), testId('field-error-count'))),
|
|
];
|
|
}
|
|
if (type === "empty") {
|
|
return [
|
|
buildHeader('EMPTY COLUMN', () => [
|
|
menuItem(clearColumn, 'Clear column', dom.cls('disabled', true)),
|
|
menuItem(() => convertIsFormula({toFormula: false}), 'Make into data column'),
|
|
]),
|
|
buildFormulaRow(),
|
|
];
|
|
} else if (type === "formula") {
|
|
return [
|
|
buildHeader('FORMULA COLUMN', () => [
|
|
menuItem(clearColumn, 'Clear column'),
|
|
menuItem(() => convertIsFormula({toFormula: false, noRecalc: true}), 'Convert to data column'),
|
|
]),
|
|
buildFormulaRow(),
|
|
];
|
|
} else {
|
|
return [
|
|
buildHeader('DATA COLUMN', () => {
|
|
return origColumn.formula.peek() ? [
|
|
// If there is a formula available, offer a separate option to convert to formula
|
|
// without clearing it.
|
|
menuItem(clearColumn, 'Clear column'),
|
|
menuItem(() => convertIsFormula({toFormula: true}), 'Convert to formula column'),
|
|
] : [
|
|
menuItem(clearColumn, 'Clear and make into formula'),
|
|
];
|
|
}),
|
|
buildFormulaRow('Optional formula'),
|
|
dom.domComputed(use => Boolean(use(origColumn.formula)), (haveFormula) => haveFormula ?
|
|
dom.create(buildFormulaTriggers, origColumn) :
|
|
cssHintRow('For default values, automatic updates, and data-cleaning.')
|
|
)
|
|
];
|
|
}
|
|
}
|
|
);
|
|
}
|
|
|
|
function buildFormula(owner: MultiHolder, column: ColumnRec, buildEditor: BuildEditor, placeholder: string) {
|
|
return cssFieldFormula(column.formula, {placeholder, maxLines: 2},
|
|
dom.cls('formula_field_sidepane'),
|
|
cssFieldFormula.cls('-disabled', column.disableModify),
|
|
cssFieldFormula.cls('-disabled-icon', use => !use(column.formula)),
|
|
dom.cls('disabled'),
|
|
{tabIndex: '-1'},
|
|
dom.on('focus', (ev, elem) => buildEditor(elem)),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Create and return an observable for the count of errors in a column, which gets updated in
|
|
* response to changes in origColumn and in user data.
|
|
*/
|
|
function createFormulaErrorObs(owner: MultiHolder, gristDoc: GristDoc, origColumn: ColumnRec) {
|
|
const errorMessage = Observable.create(owner, '');
|
|
|
|
// Count errors in origColumn when it's a formula column. Counts get cached by the
|
|
// tableData.countErrors() method, and invalidated on relevant data changes.
|
|
function countErrors() {
|
|
if (owner.isDisposed()) { return; }
|
|
const tableData = gristDoc.docData.getTable(origColumn.table.peek().tableId.peek());
|
|
const isFormula = origColumn.isRealFormula.peek() || origColumn.hasTriggerFormula.peek();
|
|
if (tableData && isFormula) {
|
|
const colId = origColumn.colId.peek();
|
|
const numCells = tableData.getColValues(colId)?.length || 0;
|
|
const numErrors = tableData.countErrors(colId) || 0;
|
|
errorMessage.set(
|
|
(numErrors === 0) ? '' :
|
|
(numCells === 1) ? `Error in the cell` :
|
|
(numErrors === numCells) ? `Errors in all ${numErrors} cells` :
|
|
`Errors in ${numErrors} of ${numCells} cells`
|
|
);
|
|
} else {
|
|
errorMessage.set('');
|
|
}
|
|
}
|
|
|
|
// Debounce the count calculation to defer it to the end of a bundle of actions.
|
|
const debouncedCountErrors = debounce(countErrors, 0);
|
|
|
|
// If there is an update to the data in the table, count errors again. Since the same UI is
|
|
// reused when different page widgets are selected, we need to re-create this subscription
|
|
// whenever the selected table changes. We use a Computed to both react to changes and dispose
|
|
// the previous subscription when it changes.
|
|
Computed.create(owner, (use) => {
|
|
const tableData = gristDoc.docData.getTable(use(use(origColumn.table).tableId));
|
|
return tableData ? use.owner.autoDispose(tableData.tableActionEmitter.addListener(debouncedCountErrors)) : null;
|
|
});
|
|
|
|
// The counts depend on the origColumn and its isRealFormula status, but with the debounced
|
|
// callback and subscription to data, subscribe to relevant changes manually (rather than using
|
|
// a Computed).
|
|
owner.autoDispose(subscribe(use => { use(origColumn.id); use(origColumn.isRealFormula); debouncedCountErrors(); }));
|
|
return errorMessage;
|
|
}
|
|
|
|
const cssFieldFormula = styled(buildHighlightedCode, `
|
|
flex: auto;
|
|
cursor: pointer;
|
|
margin-top: 4px;
|
|
padding-left: 24px;
|
|
--icon-color: ${colors.lightGreen};
|
|
|
|
&-disabled-icon.formula_field_sidepane::before {
|
|
--icon-color: ${colors.slate};
|
|
}
|
|
&-disabled {
|
|
pointer-events: none;
|
|
}
|
|
`);
|
|
|
|
const cssToggleButton = styled(cssIconButton, `
|
|
margin-left: 8px;
|
|
background-color: var(--grist-color-medium-grey-opaque);
|
|
box-shadow: inset 0 0 0 1px ${colors.darkGrey};
|
|
|
|
&-selected, &-selected:hover {
|
|
box-shadow: none;
|
|
background-color: ${colors.dark};
|
|
--icon-color: ${colors.light};
|
|
}
|
|
&-selected:hover {
|
|
--icon-color: ${colors.darkGrey};
|
|
}
|
|
`);
|
|
|
|
const cssInlineLabel = styled(cssLabel, `
|
|
padding: 4px 8px;
|
|
margin: 4px 0 -4px -8px;
|
|
`);
|
|
|
|
const cssDropdownLabel = styled(cssInlineLabel, `
|
|
margin-left: auto;
|
|
display: flex;
|
|
align-items: center;
|
|
border-radius: ${vars.controlBorderRadius};
|
|
cursor: pointer;
|
|
|
|
color: ${colors.lightGreen};
|
|
--icon-color: ${colors.lightGreen};
|
|
|
|
&:hover, &:focus, &.weasel-popup-open {
|
|
background-color: ${colors.mediumGrey};
|
|
}
|
|
&-disabled {
|
|
color: ${colors.slate};
|
|
--icon-color: ${colors.slate};
|
|
pointer-events: none;
|
|
}
|
|
`);
|
|
|
|
const cssHintRow = styled('div', `
|
|
margin: -4px 16px 8px 16px;
|
|
color: ${colors.slate};
|
|
`);
|
|
|
|
const cssColLabelBlock = styled('div', `
|
|
display: flex;
|
|
flex-direction: column;
|
|
`);
|
|
|
|
const cssColTieBlock = styled('div', `
|
|
position: relative;
|
|
`);
|
|
|
|
const cssColTieConnectors = styled('div', `
|
|
position: absolute;
|
|
border: 2px solid var(--grist-color-dark-grey);
|
|
top: -9px;
|
|
bottom: -9px;
|
|
right: 11px;
|
|
left: 0px;
|
|
border-left: none;
|
|
z-index: -1;
|
|
`);
|
|
|
|
const cssError = styled('div', `
|
|
color: ${colors.error};
|
|
`);
|