Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
460f22b701
gristlabs_grist-core/app/client/models
History
Alex Hall 460f22b701 (core) Don't show hidden tables in table data options when adding widgets 
Summary:
As reported in https://grist.slack.com/archives/C069RUP71/p1655316194602829, when a table is hidden by ACL, it was still showing as a blank 'ghost' option to select data when adding a widget:

{F55498}

The fix is simply to return `true` from `isHiddenTable` for empty table IDs, which indicate a table hidden by ACL. `TableRec.isHidden` is supposed to match this so I updated it too, and I cleaned up a tiny bit of other related code.

Test Plan: Extended `nbrowser/AccessRules1.ts` to test the data options when adding widgets.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3530
2022-07-21 16:28:28 +02:00
..
entities (core) Don't show hidden tables in table data options when adding widgets 2022-07-21 16:28:28 +02:00
AppModel.ts (core) Polishing upgrade plan UI 2022-06-29 18:28:37 +02:00
BaseRowModel.js (core) Update ACL resources/rules when tables/columns get renamed 2021-01-04 22:03:01 -05:00
BillingModel.ts (core) Improving billing page user experience 2022-07-18 14:43:14 +02:00
ClientColumnGetters.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
ColumnACIndexes.ts (core) Use visibleCol instead of displayCol with createFormatter 2021-12-16 22:19:36 +02:00
ColumnCache.ts (core) Show count of formula errors in the column config in the right-side panel. 2021-04-20 21:26:17 -04:00
ColumnFilter.ts (core) Adds new range filter for numeric columns 2022-05-30 10:30:16 +02:00
ColumnFilterMenuModel.ts (core) Fix values ordering in column filter menu 2022-05-24 16:30:28 +02:00
ColumnToMap.ts (core) Custom Widget column mapping feature. 2022-02-08 17:41:04 +01:00
ConnectState.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
DataRowModel.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
DataTableModel.js (core) move client code to core 2020-10-02 13:24:21 -04:00
DataTableModelWithDiff.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
DocData.ts (core) Wait for transform column before finalizing 2022-03-01 13:59:14 -08:00
DocModel.ts (core) Show summary tables on Raw Data page 2022-07-06 09:41:48 -07:00
DocPageModel.ts (core) Broadcast doc usage updates to clients 2022-06-06 09:55:34 -07:00
errors.ts (core) Improve debug logging related for client-side errors and sandbox crashes. 2022-04-11 17:54:40 -04:00
gristConfigCache.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
gristUrlState.ts (core) Include hash/fragment in post-login redirect URLs 2022-04-13 09:16:29 -07:00
HomeModel.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
MetaRowModel.js (core) move client code to core 2020-10-02 13:24:21 -04:00
MetaTableModel.js (core) Raw renames 2022-04-27 22:21:55 +02:00
modelUtil.js (core) move client code to core 2020-10-02 13:24:21 -04:00
NotifyModel.ts (core) Error message on Duplicate Document 2021-11-09 19:12:57 +01:00
QuerySet.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
rowset.ts (core) Fix some bugs with repositioning rows. 2022-06-07 16:55:45 -04:00
rowuid.js (core) move client code to core 2020-10-02 13:24:21 -04:00
SearchModel.ts (core) Don't show hidden tables in table data options when adding widgets 2022-07-21 16:28:28 +02:00
SectionFilter.ts (core) Speed up and upgrade build. 2022-06-27 16:10:10 -04:00
Styles.ts (core) Adding font options to the style picker 2022-04-07 20:35:03 +02:00
TableData.ts (core) Use MetaTableData more 2021-12-07 17:09:58 +02:00
TableModel.js (core) Change how formula columns can be converted to data. 2021-03-05 12:42:57 -05:00
TreeModel.ts (core) Fix some bugs with repositioning rows. 2022-06-07 16:55:45 -04:00
UserManagerModel.ts (core) Polish Access Details 2022-05-19 09:45:26 -07:00
UserPrefs.ts (core) Polishing upgrade plan UI 2022-06-29 18:28:37 +02:00
WorkspaceInfo.ts (core) move client code to core 2020-10-02 13:24:21 -04:00