You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alex Hall 225a76c9cb (core) Don't throw error in `onRecord(s)` for insufficient access for `includeColumns` ... Summary: This removes checking for full access in `onRecord/onRecords` when `includeColumns` is a non-default value. The check had two problems: 1. It relied on the access level being present in the URL query parameters, which doesn't work if the page has redirected. See the discussion in https://grist.slack.com/archives/C0234CPPXPA/p1702576602615509. There seems to be no way to reliably and synchronously check the access level. 2. Calling `onRecords` before `ready` and forgetting to handle an error from the access check meant that `ready` wouldn't be called, so Grist couldn't request the correct access level from the user. I made this mistake and it seems like a nasty footgun. Ultimately this has no effect on security, as an error will still be raised, but in a place where the widget developer can't catch it. They'll still see an error message in the console, and they can still check the access level reliably using `onOptions`, so I think this is OK. Test Plan: Updated nbrowser test Reviewers: georgegevoian, paulfitz Reviewed By: georgegevoian, paulfitz Differential Revision: https://phab.getgrist.com/D4145		5 months ago
..
aclui	(core) Avoid reporting unhelpful ResizeObserver error	7 months ago
components	(core) Don't throw error in `onRecord(s)` for insufficient access for `includeColumns`	5 months ago
lib	(core) Forms feature	5 months ago
models	(core) Forms feature	5 months ago
ui	(core) API console	5 months ago
ui2018	(core) Forms feature	5 months ago
widgets	(core) Allow adding rows to widgets filtered by a link using a formula column	6 months ago
DefaultHooks.ts	add hooks for tweaking how downloads happen (for grist-static) (#665)	9 months ago
Hooks.ts	support other SQLite wrappers, and various hooks needed by grist-static (#516)	1 year ago
app.css	(core) Polish tutorial popups	1 year ago
app.js	(core) i18	2 years ago
billingMain.ts	(core) Add basic activation page to grist-ee	2 years ago
browserCheck.ts	(core) On mobile, only show a warning for older and unknown browsers rather than for all	1 year ago
declarations.d.ts	(core) Polish new Add Column menu	8 months ago
errorMain.ts	(core) Enable MFA configuration (and add SMS)	2 years ago
exposeModulesForTests.js	support other SQLite wrappers, and various hooks needed by grist-static (#516)	1 year ago
logo.css	(core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app.	4 years ago
tsconfig.json	(core) Migrate to SRP and add change password dialog	2 years ago