You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alex Hall ecf2fdf71a (core) Fix summary table titles and linking when source table is hidden by ACL ... Summary: Two summary table widgets that share a source table and have compatible groupby columns can be filter linked. This diff fixes a bug where this linking is broken when the source table is hidden by access rules. The source table data isn't needed for the linking, but its metadata is, and that metadata is censored by GranularAccess. To deal with this: - `LinkConfig._assertValid` allows blank `tableId`s specifically for linking two summary tables. - `LinkingState.filterColValues` gets the `colId`s of groupby columns from the summary table columns rather than the source table. A closely related problem is that the titles of summary tables are incomplete when the source table is hidden, e.g. they just say `[by A]` instead of `Table1 [by A]`. To fix this, the raw view sections of source tables are 'uncensored' in GranularAccess. Initially I also planned to uncensor the tableId of the source table, which seemed like a better and more general fix for the blank tableId problem. But several parts of client code use blank tableIds to know that a table should be hidden, so they were left as is. Test Plan: Added an nbrowser test for summary table linking, and a server test for uncensoring the raw view section in GranularAccess. Reviewers: georgegevoian, paulfitz Reviewed By: georgegevoian, paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D3608		2 years ago
..
aclui	(core) If invalid tableIds are present in Access Rules, avoid browser errors to show the rules anyway	2 years ago
components	(core) Fix summary table titles and linking when source table is hidden by ACL	2 years ago
lib	(core) Fixing ACIndex highlightMatches functions	2 years ago
models	(core) Fix summary table titles and linking when source table is hidden by ACL	2 years ago
ui	(core) Fix summary table titles and linking when source table is hidden by ACL	2 years ago
ui2018	(core) Fix prevent auto-expansion when user is resizing browser window	2 years ago
widgets	(core) Showing a raw data section on a popup	2 years ago
accountMain.ts	(core) Enable MFA configuration (and add SMS)	3 years ago
activationMain.ts	(core) Add basic activation page to grist-ee	2 years ago
app.css	(core) Make mobile the default mode.	4 years ago
app.js	(core) Disable bfcache for all browsers	3 years ago
billingMain.ts	(core) Add basic activation page to grist-ee	2 years ago
browserCheck.ts	(core) fix browser check and favicon in grist-core	3 years ago
declarations.d.ts	(core) Reference columns weren't added to Raw Data Views	2 years ago
errorMain.ts	(core) Enable MFA configuration (and add SMS)	3 years ago
exposeModulesForTests.js	(core) Some cleanup: remove old unused modules.	4 years ago
logo.css	(core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app.	4 years ago
tsconfig.json	(core) Migrate to SRP and add change password dialog	3 years ago