gristlabs_grist-core/app/client
Dmitry S 3513c1e8d2 (core) In formula autocompletions, fix suggestions after an opening parenthesis.
Summary:
Previously, a change was made to include the opening parenthesis into the
"identifier regex", so that backend received the function call name for cases
like 'T.lookupOne(B' (to autocomplete columns of table T that start with "B").
Unfortunately, that interferes with common cases like 'SUM($B', since instead
of sending '$B', it is now including the function name.

To properly fix the common case, we need to exclude the function name from the
call, but for lookups we need to include it. ACE's methods aren't flexible
enough to override this logic cleanly, so some monkey-patching was needed.

Test Plan: Added a test case

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D3874
2023-04-26 15:26:44 -04:00
..
aclui (core) Fix ACL bug with rec.id in formula 2023-04-26 00:31:52 -07:00
components (core) In formula autocompletions, fix suggestions after an opening parenthesis. 2023-04-26 15:26:44 -04:00
lib (core) Adding description icon and tooltip in the GridView 2023-04-20 18:21:31 +02:00
models (core) Adding description icon and tooltip in the GridView 2023-04-20 18:21:31 +02:00
ui (core) updates from grist-core 2023-04-24 08:51:16 -04:00
ui2018 (core) Polish tutorial popups 2023-04-20 12:20:03 -04:00
widgets (core) Ignore leading whitespace in formulas, and strip out leading '=' sign users might add 2023-04-25 15:28:40 -04:00
accountMain.ts (core) Enable MFA configuration (and add SMS) 2022-01-19 13:55:54 -08:00
activationMain.ts (core) Add basic activation page to grist-ee 2022-08-23 10:30:52 -07:00
app.css (core) Polish tutorial popups 2023-04-20 12:20:03 -04:00
app.js (core) i18 2022-09-29 18:02:09 +02:00
billingMain.ts (core) Add basic activation page to grist-ee 2022-08-23 10:30:52 -07:00
browserCheck.ts (core) fix browser check and favicon in grist-core 2022-01-05 18:15:05 -05:00
declarations.d.ts (core) Migrating commands to typescript 2023-04-24 09:48:40 +02:00
errorMain.ts (core) Enable MFA configuration (and add SMS) 2022-01-19 13:55:54 -08:00
exposeModulesForTests.js (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json (core) Migrate to SRP and add change password dialog 2022-03-16 21:35:06 -07:00