mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
4ab096d179
Summary: - Support schema changes in the presence of non-trivial ACL rules. - Fix update of `aclFormulaParsed` when updating formulas automatically after schema change. - Filter private metadata in broadcasts, not just fetches. Censorship method is unchanged, just refactored. - Allow only owners to change ACL rules. - Force reloads if rules are changed. - Track rule changes within bundle, for clarity during schema changes - tableId and colId changes create a muddle otherwise. - Show or forbid pages dynamically depending on user's access to its sections. Logic unchanged, just no longer requires reload. - Fix calculation of pre-existing rows touched by a bundle, in the presence of schema changes. - Gray out acl page for non-owners. Test Plan: added tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2734
139 lines
5.6 KiB
Python
139 lines
5.6 KiB
Python
# This file used to implement (partially) old plans for granular ACLs.
|
|
# It now retains only the minimum needed to keep new documents openable by old code,
|
|
# and to produce the ActionBundles expected by other code.
|
|
|
|
import json
|
|
|
|
from acl_formula import parse_acl_grist_entities, parse_acl_formula_json
|
|
import action_obj
|
|
import logger
|
|
import textbuilder
|
|
|
|
log = logger.Logger(__name__, logger.INFO)
|
|
|
|
|
|
class Permissions(object):
|
|
# Permission types and their combination are represented as bits of a single integer.
|
|
VIEW = 0x1
|
|
UPDATE = 0x2
|
|
ADD = 0x4
|
|
REMOVE = 0x8
|
|
SCHEMA_EDIT = 0x10
|
|
ACL_EDIT = 0x20
|
|
EDITOR = VIEW | UPDATE | ADD | REMOVE
|
|
ADMIN = EDITOR | SCHEMA_EDIT
|
|
OWNER = ADMIN | ACL_EDIT
|
|
|
|
|
|
# Special recipients, or instanceIds. ALL is the special recipient for schema actions that
|
|
# should be shared with all collaborators of the document.
|
|
ALL = '#ALL'
|
|
ALL_SET = frozenset([ALL])
|
|
|
|
|
|
def acl_read_split(action_group):
|
|
"""
|
|
Returns an ActionBundle containing actions from the given action_group, all in one envelope.
|
|
With the deprecation of old-style ACL rules, envelopes are not used at all, and only kept to
|
|
avoid triggering unrelated code changes.
|
|
"""
|
|
bundle = action_obj.ActionBundle()
|
|
bundle.envelopes.append(action_obj.Envelope(ALL_SET))
|
|
bundle.stored.extend((0, da) for da in action_group.stored)
|
|
bundle.calc.extend((0, da) for da in action_group.calc)
|
|
bundle.undo.extend((0, da) for da in action_group.undo)
|
|
bundle.retValues = action_group.retValues
|
|
return bundle
|
|
|
|
|
|
def prepare_acl_table_renames(docmodel, useractions, table_renames_dict):
|
|
"""
|
|
Given a dict of table renames of the form {table_id: new_table_id}, returns a callback
|
|
that will apply updates to the affected ACL rules and resources.
|
|
"""
|
|
# If there are ACLResources that refer to the renamed table, prepare updates for those.
|
|
resource_updates = []
|
|
for resource_rec in docmodel.aclResources.all:
|
|
if resource_rec.tableId in table_renames_dict:
|
|
resource_updates.append((resource_rec, {'tableId': table_renames_dict[resource_rec.tableId]}))
|
|
|
|
# Collect updates for any ACLRules with UserAttributes that refer to the renamed table.
|
|
rule_updates = []
|
|
for rule_rec in docmodel.aclRules.all:
|
|
if rule_rec.userAttributes:
|
|
try:
|
|
rule_info = json.loads(rule_rec.userAttributes)
|
|
if rule_info.get("tableId") in table_renames_dict:
|
|
rule_info["tableId"] = table_renames_dict[rule_info.get("tableId")]
|
|
rule_updates.append((rule_rec, {'userAttributes': json.dumps(rule_info)}))
|
|
except Exception, e:
|
|
log.warn("Error examining aclRule: %s" % (e,))
|
|
|
|
def do_renames():
|
|
useractions.doBulkUpdateFromPairs('_grist_ACLResources', resource_updates)
|
|
useractions.doBulkUpdateFromPairs('_grist_ACLRules', rule_updates)
|
|
return do_renames
|
|
|
|
|
|
def prepare_acl_col_renames(docmodel, useractions, col_renames_dict):
|
|
"""
|
|
Given a dict of column renames of the form {(table_id, col_id): new_col_id}, returns a callback
|
|
that will apply updates to the affected ACL rules and resources.
|
|
"""
|
|
# Collect updates for ACLResources that refer to the renamed columns.
|
|
resource_updates = []
|
|
for resource_rec in docmodel.aclResources.all:
|
|
t = resource_rec.tableId
|
|
if resource_rec.colIds and resource_rec.colIds != '*':
|
|
new_col_ids = ','.join((col_renames_dict.get((t, c)) or c)
|
|
for c in resource_rec.colIds.split(','))
|
|
if new_col_ids != resource_rec.colIds:
|
|
resource_updates.append((resource_rec, {'colIds': new_col_ids}))
|
|
|
|
# Collect updates for any ACLRules with UserAttributes that refer to the renamed column.
|
|
rule_updates = []
|
|
user_attr_tables = {} # Maps name of user attribute to its lookup table
|
|
for rule_rec in docmodel.aclRules.all:
|
|
if rule_rec.userAttributes:
|
|
try:
|
|
rule_info = json.loads(rule_rec.userAttributes)
|
|
user_attr_tables[rule_info.get('name')] = rule_info.get('tableId')
|
|
new_col_id = col_renames_dict.get((rule_info.get("tableId"), rule_info.get("lookupColId")))
|
|
if new_col_id:
|
|
rule_info["lookupColId"] = new_col_id
|
|
rule_updates.append((rule_rec, {'userAttributes': json.dumps(rule_info)}))
|
|
except Exception, e:
|
|
log.warn("Error examining aclRule: %s" % (e,))
|
|
|
|
# Go through again checking if anything in ACL formulas is affected by the rename.
|
|
for rule_rec in docmodel.aclRules.all:
|
|
if rule_rec.aclFormula:
|
|
# Positions are obtained from unicode version of formulas, so that's what we must patch
|
|
formula = rule_rec.aclFormula.decode('utf8')
|
|
patches = []
|
|
|
|
for entity in parse_acl_grist_entities(rule_rec.aclFormula):
|
|
if entity.type == 'recCol':
|
|
table_id = docmodel.aclResources.table.get_record(int(rule_rec.resource)).tableId
|
|
elif entity.type == 'userAttrCol':
|
|
table_id = user_attr_tables.get(entity.extra)
|
|
else:
|
|
continue
|
|
col_id = entity.name
|
|
new_col_id = col_renames_dict.get((table_id, col_id))
|
|
if not new_col_id:
|
|
continue
|
|
patch = textbuilder.make_patch(
|
|
formula, entity.start_pos, entity.start_pos + len(entity.name), new_col_id)
|
|
patches.append(patch)
|
|
|
|
replacer = textbuilder.Replacer(textbuilder.Text(formula), patches)
|
|
txt = replacer.get_text().encode('utf8')
|
|
rule_updates.append((rule_rec, {'aclFormula': txt,
|
|
'aclFormulaParsed': parse_acl_formula_json(txt)}))
|
|
|
|
def do_renames():
|
|
useractions.doBulkUpdateFromPairs('_grist_ACLResources', resource_updates)
|
|
useractions.doBulkUpdateFromPairs('_grist_ACLRules', rule_updates)
|
|
return do_renames
|