mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
33f056a187
Summary: Used to throw js errors: `Resize must be passed a displayed plot div element.` Summarizing (or unsummarizing) causes the ChartView view instance to be replace by a new one in the view layout. However, the problem is that the old view instance get disposed only after the new view instance is added to the view layout. This causes the old view layout to try to resize chart while chart dom has been removed from the dom (which Plotly does not support). This diff fixes it by checking the the chart dom elemnt is still in the dom before making the plotly call to resize the chart. TODO: It feels weird that the old view instance gets disposed after the new one get added. Maybe we should check that also. Test Plan: New test added. Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3035 |
||
|---|---|---|
| .. | ||
| aclui | ||
| components | ||
| lib | ||
| models | ||
| ui | ||
| ui2018 | ||
| widgets | ||
| app.css | ||
| app.js | ||
| declarations.d.ts | ||
| errorMain.ts | ||
| exposeModulesForTests.js | ||
| logo.css | ||
| tsconfig.json | ||