mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
51ff72c15e
Summary: Building: - Builds no longer wait for tsc for either client, server, or test targets. All use esbuild which is very fast. - Build still runs tsc, but only to report errors. This may be turned off with `SKIP_TSC=1` env var. - Grist-core continues to build using tsc. - Esbuild requires ES6 module semantics. Typescript's esModuleInterop is turned on, so that tsc accepts and enforces correct usage. - Client-side code is watched and bundled by webpack as before (using esbuild-loader) Code changes: - Imports must now follow ES6 semantics: `import * as X from ...` produces a module object; to import functions or class instances, use `import X from ...`. - Everything is now built with isolatedModules flag. Some exports were updated for it. Packages: - Upgraded browserify dependency, and related packages (used for the distribution-building step). - Building the distribution now uses esbuild's minification. babel-minify is no longer used. Test Plan: Should have no behavior changes, existing tests should pass, and docker image should build too. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3506
535 lines
20 KiB
TypeScript
535 lines
20 KiB
TypeScript
import {ApiError} from 'app/common/ApiError';
|
|
import {BrowserSettings} from 'app/common/BrowserSettings';
|
|
import {delay} from 'app/common/delay';
|
|
import {CommClientConnect, CommMessage, CommResponse, CommResponseError} from 'app/common/CommTypes';
|
|
import {ErrorWithCode} from 'app/common/ErrorWithCode';
|
|
import {UserProfile} from 'app/common/LoginSessionAPI';
|
|
import {ANONYMOUS_USER_EMAIL} from 'app/common/UserAPI';
|
|
import {User} from 'app/gen-server/entity/User';
|
|
import {HomeDBManager} from 'app/gen-server/lib/HomeDBManager';
|
|
import {ActiveDoc} from 'app/server/lib/ActiveDoc';
|
|
import {Authorizer} from 'app/server/lib/Authorizer';
|
|
import {ScopedSession} from 'app/server/lib/BrowserSession';
|
|
import type {Comm} from 'app/server/lib/Comm';
|
|
import {DocSession} from 'app/server/lib/DocSession';
|
|
import log from 'app/server/lib/log';
|
|
import {LogMethods} from "app/server/lib/LogMethods";
|
|
import {shortDesc} from 'app/server/lib/shortDesc';
|
|
import {fromCallback} from 'app/server/lib/serverUtils';
|
|
import * as crypto from 'crypto';
|
|
import moment from 'moment';
|
|
import * as WebSocket from 'ws';
|
|
|
|
/// How many messages to accumulate for a disconnected client before booting it.
|
|
const clientMaxMissedMessages = 100;
|
|
|
|
export type ClientMethod = (client: Client, ...args: any[]) => Promise<unknown>;
|
|
|
|
// How long the client state persists after a disconnect.
|
|
const clientRemovalTimeoutMs = 300 * 1000; // 300s = 5 minutes.
|
|
|
|
// A hook for dependency injection.
|
|
export const Deps = {clientRemovalTimeoutMs};
|
|
|
|
/**
|
|
* Generates and returns a random string to use as a clientId. This is better
|
|
* than numbering clients with consecutive integers; otherwise a reconnecting
|
|
* client presenting the previous clientId to a restarted (new) server may
|
|
* accidentally associate itself with a wrong session that happens to share the
|
|
* same clientId. In other words, we need clientIds to be unique across server
|
|
* restarts.
|
|
* @returns {String} - random string to use as a new clientId.
|
|
*/
|
|
function generateClientId(): string {
|
|
// Non-blocking version of randomBytes may fail if insufficient entropy is available without
|
|
// blocking. If we encounter that, we could either block, or maybe use less random values.
|
|
return crypto.randomBytes(8).toString('hex');
|
|
}
|
|
|
|
/**
|
|
* These are the types of messages that are allowed to be sent to the client even if the client is
|
|
* not authorized to use this instance (e.g. not a member of the team for this subdomain).
|
|
*/
|
|
const MESSAGE_TYPES_NO_AUTH = new Set([
|
|
'clientConnect',
|
|
]);
|
|
|
|
// tslint:disable-next-line:no-unused-expression Silence "unused variable" warning.
|
|
void(MESSAGE_TYPES_NO_AUTH);
|
|
|
|
/**
|
|
* Class that encapsulates the information for a client. A Client may survive
|
|
* across multiple websocket reconnects.
|
|
* TODO: this could provide a cleaner interface.
|
|
*
|
|
* @param comm: parent Comm object
|
|
* @param websocket: websocket connection
|
|
* @param methods: a mapping from method names to server methods (must return promises)
|
|
*/
|
|
export class Client {
|
|
public readonly clientId: string;
|
|
|
|
public browserSettings: BrowserSettings = {};
|
|
|
|
private _session: ScopedSession|null = null;
|
|
|
|
private _log = new LogMethods('Client ', (extra?: object|null) => this.getLogMeta(extra || {}));
|
|
|
|
// Maps docFDs to DocSession objects.
|
|
private _docFDs: Array<DocSession|null> = [];
|
|
|
|
private _missedMessages = new Map<number, string>();
|
|
private _destroyTimer: NodeJS.Timer|null = null;
|
|
private _destroyed: boolean = false;
|
|
private _websocket: WebSocket|null;
|
|
private _org: string|null = null;
|
|
private _profile: UserProfile|null = null;
|
|
private _userId: number|null = null;
|
|
private _userName: string|null = null;
|
|
private _firstLoginAt: Date|null = null;
|
|
private _isAnonymous: boolean = false;
|
|
private _nextSeqId: number = 0; // Next sequence-ID for messages sent to the client
|
|
|
|
// Identifier for the current GristWSConnection object connected to this client.
|
|
private _counter: string|null = null;
|
|
|
|
constructor(
|
|
private _comm: Comm,
|
|
private _methods: Map<string, ClientMethod>,
|
|
private _locale: string,
|
|
) {
|
|
this.clientId = generateClientId();
|
|
}
|
|
|
|
public toString() { return `Client ${this.clientId} #${this._counter}`; }
|
|
|
|
public get locale(): string|undefined {
|
|
return this._locale;
|
|
}
|
|
|
|
public setConnection(websocket: WebSocket, counter: string|null, browserSettings: BrowserSettings) {
|
|
this._websocket = websocket;
|
|
this._counter = counter;
|
|
this.browserSettings = browserSettings;
|
|
|
|
websocket.on('error', (err) => this._onError(err));
|
|
websocket.on('close', () => this._onClose());
|
|
websocket.on('message', (msg: string) => this._onMessage(msg));
|
|
}
|
|
|
|
/**
|
|
* Returns DocSession for the given docFD, or throws an exception if this doc is not open.
|
|
*/
|
|
public getDocSession(fd: number): DocSession {
|
|
const docSession = this._docFDs[fd];
|
|
if (!docSession) {
|
|
throw new Error(`Invalid docFD ${fd}`);
|
|
}
|
|
return docSession;
|
|
}
|
|
|
|
// Adds a new DocSession to this Client, and returns the new FD for it.
|
|
public addDocSession(activeDoc: ActiveDoc, authorizer: Authorizer): DocSession {
|
|
const fd = this._getNextDocFD();
|
|
const docSession = new DocSession(activeDoc, this, fd, authorizer);
|
|
this._docFDs[fd] = docSession;
|
|
return docSession;
|
|
}
|
|
|
|
// Removes a DocSession from this Client, called when a doc is closed.
|
|
public removeDocSession(fd: number): void {
|
|
this._docFDs[fd] = null;
|
|
}
|
|
|
|
/**
|
|
* Closes all docs. Returns the number of documents closed.
|
|
*/
|
|
public closeAllDocs(): number {
|
|
let count = 0;
|
|
for (let fd = 0; fd < this._docFDs.length; fd++) {
|
|
const docSession = this._docFDs[fd];
|
|
if (docSession && docSession.activeDoc) {
|
|
// Note that this indirectly calls to removeDocSession(docSession.fd)
|
|
docSession.activeDoc.closeDoc(docSession)
|
|
.catch((e) => { this._log.warn(null, "error closing docFD %d", fd); });
|
|
count++;
|
|
}
|
|
this._docFDs[fd] = null;
|
|
}
|
|
return count;
|
|
}
|
|
|
|
public interruptConnection() {
|
|
if (this._websocket) {
|
|
this._websocket.removeAllListeners();
|
|
this._websocket.terminate(); // close() is inadequate when ws routed via loadbalancer
|
|
this._websocket = null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Sends a message to the client, queuing it up on failure or if the client is disconnected.
|
|
*/
|
|
public async sendMessage(messageObj: CommMessage|CommResponse|CommResponseError): Promise<void> {
|
|
if (this._destroyed) {
|
|
return;
|
|
}
|
|
|
|
const seqId = this._nextSeqId++;
|
|
const message: string = JSON.stringify({...messageObj, seqId});
|
|
|
|
// Log something useful about the message being sent.
|
|
if ('error' in messageObj && messageObj.error) {
|
|
this._log.warn(null, "responding to #%d ERROR %s", messageObj.reqId, messageObj.error);
|
|
}
|
|
|
|
if (this._websocket) {
|
|
// If we have a websocket, send the message.
|
|
try {
|
|
await this._sendToWebsocket(message);
|
|
} catch (err) {
|
|
// Sending failed. Add the message to missedMessages.
|
|
this._log.warn(null, "sendMessage: queuing after send error:", err.toString());
|
|
this._missedMessages.set(seqId, message);
|
|
|
|
// NOTE: A successful send does NOT mean the message was received. For a better system, see
|
|
// https://docs.microsoft.com/en-us/azure/azure-web-pubsub/howto-develop-reliable-clients
|
|
// (keeping a copy of messages until acked). With our system, we are more likely to be
|
|
// lacking the needed messages on reconnect, and having to reset the client.
|
|
}
|
|
} else if (this._missedMessages.size < clientMaxMissedMessages) {
|
|
// Queue up the message.
|
|
this._missedMessages.set(seqId, message);
|
|
} else {
|
|
// Too many messages queued. Boot the client now, to make it reset when/if it reconnects.
|
|
this._log.warn(null, "sendMessage: too many messages queued; booting client");
|
|
this.destroy();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Called from Comm.ts to decide whether this Client is available to accept a new connection
|
|
* that requests the same clientId.
|
|
*/
|
|
public canAcceptConnection(): boolean {
|
|
// Refuse reconnect if another websocket is currently active. It may be a new browser tab
|
|
// (which may reuse clientId from a copy of sessinStorage). It will need its own Client object.
|
|
return !this._websocket;
|
|
}
|
|
|
|
/**
|
|
* Complete initialization of a new connection, and send the initial 'clientConnect' message.
|
|
* See comments at the top of app/server/lib/Comm.ts for some relevant notes.
|
|
*/
|
|
public async sendConnectMessage(
|
|
newClient: boolean, reuseClient: boolean, lastSeqId: number|null, parts: Partial<CommClientConnect>
|
|
): Promise<void> {
|
|
if (this._destroyTimer) {
|
|
clearTimeout(this._destroyTimer);
|
|
this._destroyTimer = null;
|
|
}
|
|
|
|
let missedMessages: string[]|undefined = undefined;
|
|
let seamlessReconnect = false;
|
|
if (!newClient && reuseClient && await this._isAuthorized()) {
|
|
// Websocket-level reconnect: existing browser tab reconnected to an existing Client object.
|
|
// We also check that the Client is still authorized to access all open docs. If not, we'll
|
|
// close the docs and tell the Client to reload the app.
|
|
missedMessages = this.getMissedMessages(lastSeqId);
|
|
if (missedMessages) {
|
|
// We have all the needed messages (possibly an empty array); can do a seamless reconnect.
|
|
seamlessReconnect = true;
|
|
}
|
|
}
|
|
|
|
// We collected any missed messages we need; clear the stored map of them.
|
|
this._missedMessages.clear();
|
|
|
|
let docsClosed: number|null = null;
|
|
if (!seamlessReconnect) {
|
|
// The browser client can't recover from missed messages and will need to reopen docs. Close
|
|
// all docs we kept open. If it's a new Client object, this is a no-op.
|
|
docsClosed = this.closeAllDocs();
|
|
}
|
|
|
|
// An existing browser client that can't recover, or that connected to a new Client object,
|
|
// will need to reopen docs. Tell it to reload.
|
|
const needReload = !newClient && !seamlessReconnect;
|
|
|
|
this._log.debug({newClient, needReload, docsClosed, missedMessages: missedMessages?.length},
|
|
'sending clientConnect');
|
|
|
|
// Don't use sendMessage here, since we don't want to queue up this message on failure.
|
|
const clientConnectMsg: CommClientConnect = {
|
|
...parts,
|
|
type: 'clientConnect',
|
|
clientId: this.clientId,
|
|
profile: this._profile,
|
|
missedMessages,
|
|
needReload,
|
|
};
|
|
|
|
try {
|
|
await this._sendToWebsocket(JSON.stringify(clientConnectMsg));
|
|
|
|
if (needReload) {
|
|
// If the client should reload, close the socket without waiting. This connection should
|
|
// not be used anyway, and we want it released by the time the new connection comes in.
|
|
this._websocket?.close();
|
|
return;
|
|
}
|
|
|
|
// A heavy-handed fix to T396, since 'clientConnect' is sometimes not seen in the browser,
|
|
// (seemingly when the 'message' event is triggered before 'open' on the native WebSocket.)
|
|
// See also my report at https://stackoverflow.com/a/48411315/328565
|
|
await delay(250);
|
|
|
|
if (!this._destroyed && this._websocket?.readyState === WebSocket.OPEN) {
|
|
await this._sendToWebsocket(JSON.stringify({...clientConnectMsg, dup: true}));
|
|
}
|
|
} catch (err) {
|
|
// It's possible that the connection was closed while we were preparing this response.
|
|
// We just warn, and let _onClose() take care of cleanup.
|
|
this._log.warn(null, "failed to prepare or send clientConnect:", err.toString());
|
|
}
|
|
}
|
|
|
|
// Get messages in order of their key in the _missedMessages map.
|
|
public getMissedMessages(lastSeqId: number|null): string[]|undefined {
|
|
const result: string[] = [];
|
|
if (lastSeqId !== null) {
|
|
for (let i = lastSeqId + 1; i < this._nextSeqId; i++) {
|
|
const m = this._missedMessages.get(i);
|
|
if (m === undefined) { return; }
|
|
result.push(m);
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
|
|
// Assigns the given ScopedSession to the client.
|
|
public setSession(session: ScopedSession): void {
|
|
this._session = session;
|
|
}
|
|
|
|
public getSession(): ScopedSession|null {
|
|
return this._session;
|
|
}
|
|
|
|
public getAltSessionId(): string|undefined {
|
|
return this._session?.getAltSessionId();
|
|
}
|
|
|
|
/**
|
|
* Destroys a client. If the same browser window reconnects later, it will get a new Client
|
|
* object and clientId.
|
|
*/
|
|
public destroy() {
|
|
const docsClosed = this.closeAllDocs();
|
|
this._log.info({docsClosed}, "client gone");
|
|
if (this._destroyTimer) {
|
|
clearTimeout(this._destroyTimer);
|
|
this._destroyTimer = null;
|
|
}
|
|
this._missedMessages.clear();
|
|
this._comm.removeClient(this);
|
|
this._destroyed = true;
|
|
}
|
|
|
|
public setOrg(org: string): void {
|
|
this._org = org;
|
|
}
|
|
|
|
public getOrg(): string {
|
|
return this._org!;
|
|
}
|
|
|
|
public setProfile(profile: UserProfile|null): void {
|
|
this._profile = profile;
|
|
// Unset userId, so that we look it up again on demand. (Not that userId could change in
|
|
// practice via a change to profile, but let's not make any assumptions here.)
|
|
this._userId = null;
|
|
this._userName = null;
|
|
this._firstLoginAt = null;
|
|
this._isAnonymous = !profile;
|
|
}
|
|
|
|
public getProfile(): UserProfile|null {
|
|
if (this._isAnonymous) {
|
|
return {
|
|
name: 'Anonymous',
|
|
email: ANONYMOUS_USER_EMAIL,
|
|
anonymous: true,
|
|
};
|
|
}
|
|
// If we have a database, the user id and name will have been
|
|
// fetched before we start using the Client, so we take this
|
|
// opportunity to update the user name to use the latest user name
|
|
// in the database (important since user name is now exposed via
|
|
// user.Name in granular access support). TODO: might want to
|
|
// subscribe to changes in user name while the document is open.
|
|
return this._profile ? {
|
|
...this._profile,
|
|
...(this._userName && { name: this._userName }),
|
|
} : null;
|
|
}
|
|
|
|
public getCachedUserId(): number|null {
|
|
return this._userId;
|
|
}
|
|
|
|
// Returns the userId for profile.email, or null when profile is not set; with caching.
|
|
public async getUserId(dbManager: HomeDBManager): Promise<number|null> {
|
|
if (!this._userId) {
|
|
if (this._profile) {
|
|
const user = await this._fetchUser(dbManager);
|
|
this._userId = (user && user.id) || null;
|
|
this._userName = (user && user.name) || null;
|
|
this._isAnonymous = this._userId && dbManager.getAnonymousUserId() === this._userId || false;
|
|
this._firstLoginAt = (user && user.firstLoginAt) || null;
|
|
} else {
|
|
this._userId = dbManager.getAnonymousUserId();
|
|
this._userName = 'Anonymous';
|
|
this._isAnonymous = true;
|
|
this._firstLoginAt = null;
|
|
}
|
|
}
|
|
return this._userId;
|
|
}
|
|
|
|
// Returns the userId for profile.email, or throws 403 error when profile is not set.
|
|
public async requireUserId(dbManager: HomeDBManager): Promise<number> {
|
|
const userId = await this.getUserId(dbManager);
|
|
if (userId) { return userId; }
|
|
throw new ApiError(this._profile ? `user not known: ${this._profile.email}` : 'user not set', 403);
|
|
}
|
|
|
|
public getLogMeta(meta: {[key: string]: any} = {}) {
|
|
if (this._profile) { meta.email = this._profile.email; }
|
|
// We assume the _userId has already been cached, which will be true always (for all practical
|
|
// purposes) because it's set when the Authorizer checks this client.
|
|
if (this._userId) { meta.userId = this._userId; }
|
|
// Likewise for _firstLoginAt, which we learn along with _userId.
|
|
if (this._firstLoginAt) {
|
|
meta.age = Math.floor(moment.duration(moment().diff(this._firstLoginAt)).asDays());
|
|
}
|
|
if (this._org) { meta.org = this._org; }
|
|
const altSessionId = this.getAltSessionId();
|
|
if (altSessionId) { meta.altSessionId = altSessionId; }
|
|
meta.clientId = this.clientId; // identifies a client connection, essentially a websocket
|
|
meta.counter = this._counter; // identifies a GristWSConnection in the connected browser tab
|
|
return meta;
|
|
}
|
|
|
|
/**
|
|
* Processes a request from a client. All requests from a client get a response, at least to
|
|
* indicate success or failure.
|
|
*/
|
|
private async _onMessage(message: string): Promise<void> {
|
|
const request = JSON.parse(message);
|
|
if (request.beat) {
|
|
// this is a heart beat, to keep the websocket alive. No need to reply.
|
|
log.rawInfo('heartbeat', {
|
|
...this.getLogMeta(),
|
|
url: request.url,
|
|
docId: request.docId, // caution: trusting client for docId for this purpose.
|
|
});
|
|
return;
|
|
} else {
|
|
this._log.info(null, "onMessage", shortDesc(message));
|
|
}
|
|
let response: CommResponse|CommResponseError;
|
|
const method = this._methods.get(request.method);
|
|
if (!method) {
|
|
response = {reqId: request.reqId, error: `Unknown method ${request.method}`};
|
|
} else {
|
|
try {
|
|
response = {reqId: request.reqId, data: await method(this, ...request.args)};
|
|
} catch (error) {
|
|
const err: ErrorWithCode = error;
|
|
// Print the error stack, except for SandboxErrors, for which the JS stack isn't that useful.
|
|
// Also not helpful is the stack of AUTH_NO_VIEW|EDIT errors produced by the Authorizer.
|
|
const code: unknown = err.code;
|
|
const skipStack = (
|
|
!err.stack ||
|
|
err.stack.match(/^SandboxError:/) ||
|
|
(typeof code === 'string' && code.startsWith('AUTH_NO'))
|
|
);
|
|
|
|
this._log.warn(null, "Error %s %s", skipStack ? err : err.stack, code || '');
|
|
response = {reqId: request.reqId, error: err.message};
|
|
if (err.code) {
|
|
response.errorCode = err.code;
|
|
}
|
|
if (err.details) {
|
|
response.details = err.details;
|
|
}
|
|
if (typeof code === 'string' && code === 'AUTH_NO_EDIT' && err.accessMode === 'fork') {
|
|
response.shouldFork = true;
|
|
}
|
|
}
|
|
}
|
|
await this.sendMessage(response);
|
|
}
|
|
|
|
// Fetch the user database record from profile.email, or null when profile is not set.
|
|
private async _fetchUser(dbManager: HomeDBManager): Promise<User|undefined> {
|
|
return this._profile && this._profile.email ?
|
|
await dbManager.getUserByLogin(this._profile.email) :
|
|
undefined;
|
|
}
|
|
|
|
// Check that client still has access to all documents. Used to determine whether
|
|
// a Comm client can be safely reused after a reconnect. Without this check, the client
|
|
// would be reused even if access to a document has been lost (although an error would be
|
|
// issued later, on first use of the document).
|
|
private async _isAuthorized(): Promise<boolean> {
|
|
for (const docFD of this._docFDs) {
|
|
try {
|
|
if (docFD !== null) { await docFD.authorizer.assertAccess('viewers'); }
|
|
} catch (e) {
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
// Returns the next unused docFD number.
|
|
private _getNextDocFD(): number {
|
|
let fd = 0;
|
|
while (this._docFDs[fd]) { fd++; }
|
|
return fd;
|
|
}
|
|
|
|
private _sendToWebsocket(message: string): Promise<void> {
|
|
return fromCallback(cb => this._websocket!.send(message, cb));
|
|
}
|
|
|
|
/**
|
|
* Processes an error on the websocket.
|
|
*/
|
|
private _onError(err: unknown) {
|
|
this._log.warn(null, "onError", err);
|
|
// TODO Make sure that this is followed by onClose when the connection is lost.
|
|
}
|
|
|
|
/**
|
|
* Processes the closing of a websocket.
|
|
*/
|
|
private _onClose() {
|
|
this._websocket?.removeAllListeners();
|
|
|
|
// Remove all references to the websocket.
|
|
this._websocket = null;
|
|
|
|
// Schedule the client to be destroyed after a timeout. The timer gets cleared if the same
|
|
// client reconnects in the interim.
|
|
if (this._destroyTimer) {
|
|
this._log.warn(null, "clearing previously scheduled destruction");
|
|
clearTimeout(this._destroyTimer);
|
|
}
|
|
this._log.info(null, "websocket closed; will discard client in %s sec", Deps.clientRemovalTimeoutMs / 1000);
|
|
this._destroyTimer = setTimeout(() => this.destroy(), Deps.clientRemovalTimeoutMs);
|
|
}
|
|
}
|