mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
d99db8d016
Summary: * Tie build and run-time docker base images to a consistent version (buster) * Extend the test login system activated by GRIST_TEST_LOGIN to ease porting tests that currently rely on cognito (many) * Make org resets work in absence of billing endpoints * When in-memory session caches are used, add missing invalidation steps * Pass org information through sign-ups/sign-ins more carefully * For CORS, explicitly trust GRIST_HOST origin when set * Move some fixtures and tests to core, focussing on tests that cover existing failures or are in the set of tests run on deployments * Retain regular `test` target to run the test suite directly, without docker * Add a `test:smoke` target to run a single simple test without `GRIST_TEST_LOGIN` activated * Add a `test:docker` target to run the tests against a grist-core docker image - since tests rely on certain fixture teams/docs, added `TEST_SUPPORT_API_KEY` and `TEST_ADD_SAMPLES` flags to ease porting The tests ported were `nbrowser` tests: `ActionLog.ts` (the first test I tend to port to anything, out of habit), `Fork.ts` (exercises a lot of doc creation paths), `HomeIntro.ts` (a lot of DocMenu exercise), and `DuplicateDocument.ts` (covers a feature known to be failing prior to this diff, the CORS tweak resolves it). Test Plan: Manually tested via `buildtools/build_core.sh`. In follow up, I want to add running the `test:docker` target in grist-core's workflows. In jenkins, only the smoke test is run. There'd be an argument for running all tests, but they include particularly slow tests, and are duplicates of tests already run (in different configuration admittedly), so I'd like to try first just using them in grist-core to gate updates to any packaged version of Grist (the docker image currently). Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3176
208 lines
7.5 KiB
TypeScript
208 lines
7.5 KiB
TypeScript
import * as net from 'net';
|
|
|
|
import {UserProfile} from 'app/common/LoginSessionAPI';
|
|
import {Deps as ActiveDocDeps} from 'app/server/lib/ActiveDoc';
|
|
import {Deps as DiscourseConnectDeps} from 'app/server/lib/DiscourseConnect';
|
|
import * as Comm from 'app/server/lib/Comm';
|
|
import * as log from 'app/server/lib/log';
|
|
import {IMessage, Rpc} from 'grain-rpc';
|
|
import {Request} from 'express';
|
|
import * as t from 'ts-interface-checker';
|
|
import {FlexServer} from './FlexServer';
|
|
import {ITestingHooks} from './ITestingHooks';
|
|
import ITestingHooksTI from './ITestingHooks-ti';
|
|
import {connect, fromCallback} from './serverUtils';
|
|
import {WidgetRepositoryImpl} from 'app/server/lib/WidgetRepository';
|
|
|
|
const tiCheckers = t.createCheckers(ITestingHooksTI, {UserProfile: t.name("object")});
|
|
|
|
export function startTestingHooks(socketPath: string, port: number,
|
|
comm: Comm, flexServer: FlexServer,
|
|
workerServers: FlexServer[]): Promise<net.Server> {
|
|
// Create socket server listening on the given path for testing connections.
|
|
return new Promise((resolve, reject) => {
|
|
const server = net.createServer();
|
|
server.on('error', reject);
|
|
server.on('listening', () => resolve(server));
|
|
server.on('connection', socket => {
|
|
// On connection, create an Rpc object communicating over that socket.
|
|
const rpc = connectToSocket(new Rpc({logger: {}}), socket);
|
|
// Register the testing implementation.
|
|
rpc.registerImpl('testing',
|
|
new TestingHooks(port, comm, flexServer, workerServers),
|
|
tiCheckers.ITestingHooks);
|
|
});
|
|
server.listen(socketPath);
|
|
});
|
|
}
|
|
|
|
function connectToSocket(rpc: Rpc, socket: net.Socket): Rpc {
|
|
socket.setEncoding('utf8');
|
|
socket.on('data', (buf: string) => rpc.receiveMessage(JSON.parse(buf)));
|
|
rpc.setSendMessage((m: IMessage) => fromCallback(cb => socket.write(JSON.stringify(m), 'utf8', cb)));
|
|
return rpc;
|
|
}
|
|
|
|
export interface TestingHooksClient extends ITestingHooks {
|
|
close(): void;
|
|
}
|
|
|
|
export async function connectTestingHooks(socketPath: string): Promise<TestingHooksClient> {
|
|
const socket = await connect(socketPath);
|
|
const rpc = connectToSocket(new Rpc({logger: {}}), socket);
|
|
return Object.assign(rpc.getStub<TestingHooks>('testing', tiCheckers.ITestingHooks), {
|
|
close: () => socket.end(),
|
|
});
|
|
}
|
|
|
|
export class TestingHooks implements ITestingHooks {
|
|
constructor(
|
|
private _port: number,
|
|
private _comm: Comm,
|
|
private _server: FlexServer,
|
|
private _workerServers: FlexServer[]
|
|
) {}
|
|
|
|
public async getOwnPort(): Promise<number> {
|
|
log.info("TestingHooks.getOwnPort called");
|
|
return this._server.getOwnPort();
|
|
}
|
|
|
|
public async getPort(): Promise<number> {
|
|
log.info("TestingHooks.getPort called");
|
|
return this._port;
|
|
}
|
|
|
|
public async setLoginSessionProfile(gristSidCookie: string, profile: UserProfile|null, org?: string): Promise<void> {
|
|
log.info("TestingHooks.setLoginSessionProfile called with", gristSidCookie, profile, org);
|
|
const sessionId = this._comm.getSessionIdFromCookie(gristSidCookie);
|
|
const scopedSession = this._comm.getOrCreateSession(sessionId, {org});
|
|
const req = {} as Request;
|
|
await scopedSession.updateUserProfile(req, profile);
|
|
this._server.getSessions().clearCacheIfNeeded({email: profile?.email, org});
|
|
}
|
|
|
|
public async setServerVersion(version: string|null): Promise<void> {
|
|
log.info("TestingHooks.setServerVersion called with", version);
|
|
this._comm.setServerVersion(version);
|
|
for (const server of this._workerServers) {
|
|
server.getComm().setServerVersion(version);
|
|
}
|
|
}
|
|
|
|
public async disconnectClients(): Promise<void> {
|
|
log.info("TestingHooks.disconnectClients called");
|
|
this._comm.destroyAllClients();
|
|
for (const server of this._workerServers) {
|
|
server.getComm().destroyAllClients();
|
|
}
|
|
}
|
|
|
|
public async commShutdown(): Promise<void> {
|
|
log.info("TestingHooks.commShutdown called");
|
|
await this._comm.testServerShutdown();
|
|
for (const server of this._workerServers) {
|
|
await server.getComm().testServerShutdown();
|
|
}
|
|
}
|
|
|
|
public async commRestart(): Promise<void> {
|
|
log.info("TestingHooks.commRestart called");
|
|
await this._comm.testServerRestart();
|
|
for (const server of this._workerServers) {
|
|
await server.getComm().testServerRestart();
|
|
}
|
|
}
|
|
|
|
// Set how long new clients will persist after disconnection.
|
|
// Call with 0 to return to default duration.
|
|
public async commSetClientPersistence(ttlMs: number) {
|
|
log.info("TestingHooks.setClientPersistence called with", ttlMs);
|
|
this._comm.testSetClientPersistence(ttlMs);
|
|
for (const server of this._workerServers) {
|
|
server.getComm().testSetClientPersistence(ttlMs);
|
|
}
|
|
}
|
|
|
|
public async closeDocs(): Promise<void> {
|
|
log.info("TestingHooks.closeDocs called");
|
|
if (this._server) {
|
|
await this._server.closeDocs();
|
|
}
|
|
for (const server of this._workerServers) {
|
|
await server.closeDocs();
|
|
}
|
|
}
|
|
|
|
public async setDocWorkerActivation(workerId: string, active: 'active'|'inactive'|'crash'):
|
|
Promise<void> {
|
|
log.info("TestingHooks.setDocWorkerActivation called with", workerId, active);
|
|
for (const server of this._workerServers) {
|
|
if (server.worker.id === workerId || server.worker.publicUrl === workerId) {
|
|
switch (active) {
|
|
case 'active':
|
|
await server.restartListening();
|
|
break;
|
|
case 'inactive':
|
|
await server.stopListening();
|
|
break;
|
|
case 'crash':
|
|
await server.stopListening('crash');
|
|
break;
|
|
}
|
|
return;
|
|
}
|
|
}
|
|
throw new Error(`could not find worker: ${workerId}`);
|
|
}
|
|
|
|
public async flushAuthorizerCache(): Promise<void> {
|
|
log.info("TestingHooks.flushAuthorizerCache called");
|
|
this._server.getHomeDBManager().flushDocAuthCache();
|
|
for (const server of this._workerServers) {
|
|
server.getHomeDBManager().flushDocAuthCache();
|
|
}
|
|
}
|
|
|
|
// Returns a Map from docId to number of connected clients for all open docs across servers,
|
|
// but represented as an array of pairs, to be serializable.
|
|
public async getDocClientCounts(): Promise<Array<[string, number]>> {
|
|
log.info("TestingHooks.getDocClientCounts called");
|
|
const counts = new Map<string, number>();
|
|
for (const server of [this._server, ...this._workerServers]) {
|
|
const c = await server.getDocClientCounts();
|
|
for (const [key, val] of c) {
|
|
counts.set(key, (counts.get(key) || 0) + val);
|
|
}
|
|
}
|
|
return Array.from(counts);
|
|
}
|
|
|
|
// Sets the seconds for ActiveDoc timeout, and returns the previous value.
|
|
public async setActiveDocTimeout(seconds: number): Promise<number> {
|
|
const prev = ActiveDocDeps.ACTIVEDOC_TIMEOUT;
|
|
ActiveDocDeps.ACTIVEDOC_TIMEOUT = seconds;
|
|
return prev;
|
|
}
|
|
|
|
// Sets env vars for the DiscourseConnect module, and returns the previous value.
|
|
public async setDiscourseConnectVar(varName: string, value: string|null): Promise<string|null> {
|
|
const key = varName as keyof typeof DiscourseConnectDeps;
|
|
const prev = DiscourseConnectDeps[key] || null;
|
|
if (value == null) {
|
|
delete DiscourseConnectDeps[key];
|
|
} else {
|
|
DiscourseConnectDeps[key] = value;
|
|
}
|
|
return prev;
|
|
}
|
|
|
|
public async setWidgetRepositoryUrl(url: string): Promise<void> {
|
|
const repo = this._server.getWidgetRepository() as WidgetRepositoryImpl;
|
|
if (!(repo instanceof WidgetRepositoryImpl)) {
|
|
throw new Error("Unsupported widget repository");
|
|
}
|
|
repo.testOverrideUrl(url);
|
|
}
|
|
}
|