Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2025-06-13 20:53:59 +00:00
Code Issues Projects Releases Wiki Activity
30866c6c95
gristlabs_grist-core/app/server/lib
History
Dmitry S 30866c6c95 (core) Fix two issues combining to report misleading error when saving to an empty name 
Summary:
1. The /import endpoint wasn't handling poor names like ".grist" as
   intended, instead trying to import them using the plugin-based imports.

2. The SaveCopy dialog was allowing users to save to an empty name,
   particularly bad because new docs now default to an empty name.

Error manifested as "Cannot parse data" to the user.
Reported in https://secure.helpscout.net/conversation/1242629116/292

Test Plan: Added tests for both parts of the fix.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2573
2020-08-03 19:53:29 -04:00
..
ActionHistory.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActionHistoryImpl.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActionSummary.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActiveDoc.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActiveDocImport.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
AppEndpoint.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Authorizer.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
BrowserSession.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
checksumFile.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Client.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Comm.js (core) move home server into core 2020-07-21 20:39:10 -04:00
dbUtils.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocApi.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocClients.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocManager.ts (core) Fix two issues combining to report misleading error when saving to an empty name 2020-08-03 19:53:29 -04:00
DocPluginData.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocPluginManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocSession.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocSnapshots.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocStorage.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocStorageManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
docUtils.d.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
docUtils.js (core) move home server into core 2020-07-21 20:39:10 -04:00
DocWorker.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocWorkerMap.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ExpandedQuery.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
expressWrap.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ExternalStorage.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
extractOrg.ts (core) add a deployment test for Import-from-URL, and fix underlying issue 2020-07-23 11:26:16 -04:00
FileParserElement.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
FlexServer.ts (core) add a deployment test for Import-from-URL, and fix underlying issue 2020-07-23 11:26:16 -04:00
GristServer.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
gristSessions.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
guessExt.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
HostedMetadataManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
HostedStorageManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
IBilling.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ICreate.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
IDocStorageManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
idUtils.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
IElectionStore.ts (core) move some material to core that slipped through in a rebase 2020-07-23 11:29:05 -04:00
IInstanceManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ILoginSession.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
INotifier.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ISandbox.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
IShell.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ITestingHooks-ti.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ITestingHooks.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
log.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
manifest.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
NSandbox.ts (core) move data engine code to core 2020-07-29 08:57:25 -04:00
OnDemandActions.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Permit.ts (core) move some material to core that slipped through in a rebase 2020-07-23 11:29:05 -04:00
places.ts (core) fix docker packaging after core shuffle 2020-07-22 14:45:42 -04:00
PluginEndpoint.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
PluginManager.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
requestUtils.ts (core) Allow the support user to access everyone's billing pages 2020-07-22 15:45:47 -04:00
SafePythonComponent.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
sandboxUtil.js (core) move home server into core 2020-07-21 20:39:10 -04:00
sendAppPage.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ServerColumnGetters.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ServerMetrics.js (core) move home server into core 2020-07-21 20:39:10 -04:00
serverUtils.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Sessions.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Sharing.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
shortDesc.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
shutdown.js (core) move home server into core 2020-07-21 20:39:10 -04:00
SQLiteDB.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
TagChecker.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
TestingHooks.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Throttle.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
TimeQuery.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
UnsafeNodeComponent.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
uploads.ts (core) add a deployment test for Import-from-URL, and fix underlying issue 2020-07-23 11:26:16 -04:00
WorkCoordinator.ts (core) move home server into core 2020-07-21 20:39:10 -04:00