mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
8ee23f5344
Summary: Fixing https://gristlabs.getgrist.com/doc/check-ins/p/12#a1.s19.r1045.c19 : > Problem: user creates fresh new empty column. Users with access to write to that column, but not modify schema, will not in fact be able to write into it (since on first data entry column type needs to change). Experience is confusing. Refactored `enter_indirection` and `leave_indirection` to a single context manager method for use with `with` instead of `try/finally`. Used the new method in `_ensure_column_accepts_data` around column changing actions converting empty column to data column. Test Plan: Updated a Python test, reflecting that the correct actions are now marked as direct=False. Tested manually that I can now add data to a blank column without schema access, while I wasn't able to before, and I still can't make other schema changes. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3446 |
||
|---|---|---|
| .. | ||
| docker | ||
| grist | ||
| gvisor | ||
| gen_js_schema.py | ||
| install_tz.js | ||
| requirements3.txt | ||
| requirements.txt | ||
| run.sh | ||
| watch.sh | ||