mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
592a43ec36
Summary:
- Added a new special page for viewing raw data widgets:
- Implemented in DataTables.ts
- Accessible only via the special URL path `/p/data`
- Future diffs should make this page prettier and easily accessible
- Shows a list of user tables
- Clicking on a table name shows its `rawViewSection` by setting `GristDoc.viewModel.activeSectionId`. Note that in this case `GristDoc.viewModel` is an empty record, so this is a bit of a hack, but it works well and causes no known issues.
- Added `ViewSectionRec.isRaw` to know if the record represents a raw data widget.
- Added various restrictions in the UI for raw data widgets:
- 'Delete widget' is disabled in the 3-dot widget menu.
- Prevent hiding columns:
- "Hide column" in the column context menu is disabled
- The "VISIBLE/HIDDEN COLUMNS" section of the right panel > Table > Widget is hidden
- The toggle bar isn't configurable to ensure that users know when raw data is filtered:
- The filter bar always shows if and only if some filters are present
- "Toggle Filter Bar" is hidden in:
- Right panel > Table > Sort & Filter
- The sort/filter menu next to the three-dot menu for widgets.
- Other restrictions in the right panel:
- In the Column tab:
- 'Use separate settings' is disabled
- In the Table tab:
- In the Widget subtab:
- 'Change Widget' is hidden
- In the Data subtab:
- 'Edit Data Selection' is hidden
- 'SELECT BY' is hidden
Test Plan: Tested manually. The behaviour of raw data widgets may still change and they aren't easily visible to users yet.
Reviewers: georgegevoian
Reviewed By: georgegevoian
Differential Revision: https://phab.getgrist.com/D3248
58 lines
2.4 KiB
TypeScript
58 lines
2.4 KiB
TypeScript
import {allCommands} from 'app/client/components/commands';
|
|
import {ViewSectionRec} from 'app/client/models/DocModel';
|
|
import {testId} from 'app/client/ui2018/cssVars';
|
|
import {menuDivider, menuItemCmd, menuItemLink} from 'app/client/ui2018/menus';
|
|
import {dom} from 'grainjs';
|
|
|
|
/**
|
|
* Returns a list of menu items for a view section.
|
|
*/
|
|
export function makeViewLayoutMenu(viewSection: ViewSectionRec, isReadonly: boolean) {
|
|
const viewInstance = viewSection.viewInstance.peek()!;
|
|
const gristDoc = viewInstance.gristDoc;
|
|
|
|
// get current row index from cursor
|
|
const cursorRow = viewInstance.cursor.rowIndex.peek();
|
|
// get row id from current data
|
|
// rowId can be string - it is wrongly typed in cursor and in viewData
|
|
const rowId = (cursorRow !== null ? viewInstance.viewData.getRowId(cursorRow) : null) as string|null|number;
|
|
const isAddRow = rowId === 'new';
|
|
|
|
const contextMenu = [
|
|
menuItemCmd(allCommands.deleteRecords,
|
|
'Delete record',
|
|
testId('section-delete-card'),
|
|
dom.cls('disabled', isReadonly || isAddRow)),
|
|
menuItemCmd(allCommands.copyLink,
|
|
'Copy anchor link',
|
|
testId('section-card-link'),
|
|
),
|
|
menuDivider(),
|
|
];
|
|
|
|
const viewRec = viewSection.view();
|
|
return [
|
|
dom.maybe((use) => ['single'].includes(use(viewSection.parentKey)), () => contextMenu),
|
|
menuItemCmd(allCommands.printSection, 'Print widget', testId('print-section')),
|
|
menuItemLink({ href: gristDoc.getCsvLink(), target: '_blank', download: ''},
|
|
'Download as CSV', testId('download-section')),
|
|
dom.maybe((use) => ['detail', 'single'].includes(use(viewSection.parentKey)), () =>
|
|
menuItemCmd(allCommands.editLayout, 'Edit Card Layout',
|
|
dom.cls('disabled', isReadonly))),
|
|
|
|
menuDivider(),
|
|
menuItemCmd(allCommands.viewTabOpen, 'Widget options', testId('widget-options')),
|
|
menuItemCmd(allCommands.sortFilterTabOpen, 'Advanced Sort & Filter'),
|
|
menuItemCmd(allCommands.dataSelectionTabOpen, 'Data selection'),
|
|
|
|
menuDivider(),
|
|
dom.maybe((use) => use(viewSection.parentKey) === 'custom' && use(viewSection.hasCustomOptions), () =>
|
|
menuItemCmd(allCommands.openWidgetConfiguration, 'Open configuration',
|
|
testId('section-open-configuration')),
|
|
),
|
|
menuItemCmd(allCommands.deleteSection, 'Delete widget',
|
|
dom.cls('disabled', !viewRec.getRowId() || viewRec.viewSections().peekLength <= 1 || isReadonly),
|
|
testId('section-delete')),
|
|
];
|
|
}
|