gristlabs_grist-core/app/client
Jarosław Sadziński 24dca831c0 (core) Renaming column by clicking away resulted in renaming different column.
Summary:
Bug summary: if in right bar user starts changing name of column, but then clicks on a different column name in table, THAT column will have its name changed.

This bug occurs because the save method is invoked by a blur event on a input field, which is triggered after all computed observables are calculated. Save method gets an observable to update, which by the time a blur event triggers, is changed to a new column.

The solution was to forcefully trigger the blur event as soon as possible - here by subscribing to the cursor position observable.

Test Plan: Browser tests

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2845
2021-06-08 20:27:06 +02:00
..
aclui (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
components (core) Showing censored values as a grey cell 2021-06-07 13:11:41 +02:00
lib (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
models (core) Prevents running simultaneous search in parallel inadvertendly 2021-05-28 15:48:21 +02:00
ui (core) Renaming column by clicking away resulted in renaming different column. 2021-06-08 20:27:06 +02:00
ui2018 (core) Add Lock icon 2021-06-01 13:10:57 -04:00
widgets (core) Showing censored values as a grey cell 2021-06-07 13:11:41 +02:00
app.css (core) Make mobile the default mode. 2021-02-25 11:31:43 -05:00
app.js (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
declarations.d.ts (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
exposeModulesForTests.js (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json freshen app/client/ui2018/cssVars.ts 2020-06-23 16:16:38 -04:00