mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 19:10:44 +00:00
193d5360ad
Summary:
Diff fixes an annoying issue when the left panel would sometimes
auto-expand when the user is resizing the window. Alghouth it is quite
easy to reproduce the issue still would happen a bit randomly.
Here are what was done to fix it:
1) The most annoying manifestation of the issue happens with doc menu
page. Indeed the panel is not meant to be collapsing hence triggering
overlapping expansion messes UI a great deal. This was fix by
asserting that the panel was collapsible before triggering expansion
`if (left.hideOpener) { return; }`.
2) To prevent issue to happen also with doc page, we first test
whether the user is actually dragging using `ev1.buttons !== 0` and
also we've added a `isScreeResizingObs` observable. Although this
seems to have fixed the problem for me, other developers still
reports occurence of the issue on there machine but at a lesser
frequence. It is unknown what this solution does not fully work,
still situation seems acceptable now (most annoying part was 1st
item).
Diff also brings another small improvement when using Grist in a split
screen setup when Grist is on the right. Moving cursor back and forth
between the two windows would frequently leave the left panel
inadvertandly expanded. Diff added a fix to allow panel to collapse
when cursor leave window.
Test Plan: Tested manually as it is hard to test when selenium.
Reviewers: georgegevoian
Reviewed By: georgegevoian
Differential Revision: https://phab.getgrist.com/D3562
|
||
|---|---|---|
| .. | ||
| breadcrumbs.ts | ||
| buttons.ts | ||
| buttonSelect.ts | ||
| checkbox.ts | ||
| ColorPalette.ts | ||
| ColorSelect.ts | ||
| cssVars.ts | ||
| draggableList.ts | ||
| editableLabel.ts | ||
| IconList.ts | ||
| icons.ts | ||
| links.ts | ||
| loaders.ts | ||
| menus.ts | ||
| modals.ts | ||
| pages.ts | ||
| search.ts | ||
| select.ts | ||