gristlabs_grist-core/app/gen-server
Paul Fitzpatrick d0d3d3d0c9 (core) discount indirect changes for access control purposes
Summary:
This diff discounts indirect changes for access control purposes.  A UserAction that updates a cell A, which in turn causes changes in other dependent cells, will be considered a change to cell A for access control purposes.

The `engine.apply_user_actions` method now returns a `direct` array, with a boolean for each `stored` action, set to `true` if the action is attributed to the user or `false` if it is attributed to the engine.  `GranularAccess` ignores actions attributed to the engine when checking for edit rights.

Subtleties:
 * Removal of references to a removed row are considered direct changes.
 * Doesn't play well with undos as yet.  An action that indirectly modifies a cell the user doesn't have rights to may succeed, but it will not be reversible.

Test Plan: added tests, updated tests

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2806
2021-05-12 11:26:21 -04:00
..
entity (core) add per-user per-org preferences to database 2020-08-04 15:20:13 -04:00
lib (core) discount indirect changes for access control purposes 2021-05-12 11:26:21 -04:00
migration (core) add per-user per-org preferences to database 2020-08-04 15:20:13 -04:00
ApiServer.ts (core) revamp user attribute handling 2020-12-11 15:15:35 -05:00
sqlUtils.ts (core) add a test for unnecessary workspaces shown in trash, and fix issue 2020-07-23 11:04:33 -04:00