You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alex Hall 225a76c9cb (core) Don't throw error in `onRecord(s)` for insufficient access for `includeColumns` ... Summary: This removes checking for full access in `onRecord/onRecords` when `includeColumns` is a non-default value. The check had two problems: 1. It relied on the access level being present in the URL query parameters, which doesn't work if the page has redirected. See the discussion in https://grist.slack.com/archives/C0234CPPXPA/p1702576602615509. There seems to be no way to reliably and synchronously check the access level. 2. Calling `onRecords` before `ready` and forgetting to handle an error from the access check meant that `ready` wouldn't be called, so Grist couldn't request the correct access level from the user. I made this mistake and it seems like a nasty footgun. Ultimately this has no effect on security, as an error will still be raised, but in a place where the widget developer can't catch it. They'll still see an error message in the console, and they can still check the access level reliably using `onOptions`, so I think this is OK. Test Plan: Updated nbrowser test Reviewers: georgegevoian, paulfitz Reviewed By: georgegevoian, paulfitz Differential Revision: https://phab.getgrist.com/D4145		4 months ago
..
config	(core) Extending widget	7 months ago
deferred-ready	(core) Support dark mode in custom widgets	8 months ago
embed	(core) Moving widget tests to core	2 years ago
fetchSelectedOptions	(core) Don't throw error in `onRecord(s)` for insufficient access for `includeColumns`	4 months ago
filter	(core) Moving widget tests to core	2 years ago
hello	(core) Cursor in custom widgets	9 months ago
paste	(core) Moving widget tests to core	2 years ago
probe	(core) Moving widget tests to core	2 years ago
readout	(core) Add Command API to Grist Plugin API	8 months ago
types	(core) Moving widget tests to core	2 years ago
zap	(core) Moving widget tests to core	2 years ago