gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Dmitry S	8a2a14ce74	(core) Fix double-tap on Android failing to select tapped cell; ensure gestures don't get interpreted as double-tap Summary: This solves the issue of double-tapping cells when NOT in mobile mode, which is caused by delayed simulation of click events. (In mobile mode, modern browsers don't add a delay either way.) Also avoid unintended opening of the editor by checking that the double-tap is on the same cell. Test Plan: Tested manually on iPhone and Chrome emulator. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2727	4 years ago
Dmitry S	7284644313	(core) Add support for editing on mobile. Summary: - Add custom handling for dblclick on mobile, to allow focusing editor. - In place of Clipboard.js, use a FocusLayer with document.body as the default focus element. - Set maximum-scale on iOS viewport to prevent auto-zoom. - Reposition the editor on window resize when editing a cell, which is a normal occurrence on Android when virtual keyboard is shown. - Add Save/Cancel icon-buttons next to cell editor on mobile. Test Plan: Tested manually on Safari / FF on iPhone, and on Chrome on Android emulator. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2721	4 years ago

Author

SHA1

Message

Date

Dmitry S

8a2a14ce74

(core) Fix double-tap on Android failing to select tapped cell; ensure gestures don't get interpreted as double-tap

Summary:
This solves the issue of double-tapping cells when NOT in mobile mode, which is
caused by delayed simulation of click events. (In mobile mode, modern browsers
don't add a delay either way.)

Also avoid unintended opening of the editor by checking that the double-tap is
on the same cell.

Test Plan: Tested manually on iPhone and Chrome emulator.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2727

Dmitry S

7284644313

(core) Add support for editing on mobile.

Summary:
- Add custom handling for dblclick on mobile, to allow focusing editor.
- In place of Clipboard.js, use a FocusLayer with document.body as the default focus element.
- Set maximum-scale on iOS viewport to prevent auto-zoom.
- Reposition the editor on window resize when editing a cell, which is a normal
  occurrence on Android when virtual keyboard is shown.
- Add Save/Cancel icon-buttons next to cell editor on mobile.

Test Plan: Tested manually on Safari / FF on iPhone, and on Chrome on Android emulator.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2721

2 Commits (ffe3b2237865bed1d0833915750794a31953c3f1)